GNOME Bugzilla – Bug 322989
build fails with gnome-2.13.x
Last modified: 2006-05-06 09:35:36 UTC
Distribution/Version: Fedora Core 4 cc -DHAVE_CONFIG_H -I. -I. -I.. -DG_LOG_DOMAIN=\"GNet\" -DG_ENABLE_DEBUG -I/home/gnome/g-2.13.cvs/include/glib-2.0 -I/home/gnome/g-2.13.cvs/lib/glib-2.0/include -pthread -I/home/gnome/g-2.13.cvs/include/glib-2.0 -I/home/gnome/g-2.13.cvs/lib/glib-2.0/include -I/home/gnome/g-2.13.cvs/include -g -I/home/gnome/g-2.13.cvs/include -L/home/gnome/g-2.13.cvs/lib -O2 -pipe -march=athlon-xp -m3dnow -D_REENTRANT -DGNET_EXPERIMENTAL -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Werror -MT tcp.lo -MD -MP -MF .deps/tcp.Tpo -c tcp.c -fPIC -DPIC -o .libs/tcp.o cc1: warnings being treated as errors tcp.c: In function 'gnet_tcp_socket_new_async_cb': tcp.c:492: warning: pointer targets in passing argument 5 of 'getsockopt' differ in signedness make[3]: *** [tcp.lo] Error 1 make[3]: Leaving directory `/mnt/hdb1/home/gnome/garnome-2.13.cvs/fifth-toe/gnet/work/main.d/gnet-2.0.7/src'
Created attachment 55507 [details] [review] Patch to fix build failure
Sorry, this one got lost in my inbox somewhere. What are the prototypes for getsockopt and recvfrom on your system? I don't really want to cast to (void*) as this might cover up potential integer size issues in other circumstances. The other things should be fixed in CVS already. Cheers -Tim
Hi, Tim. I'm running Fedora Core 4 x86. :) /* Read N bytes into BUF through socket FD. If ADDR is not NULL, fill in *ADDR_LEN bytes of it with tha address of the sender, and store the actual size of the address in *ADDR_LEN. Returns the number of bytes read or -1 for errors. This function is a cancellation point and therefore not marked with __THROW. */ extern ssize_t recvfrom (int __fd, void *__restrict __buf, size_t __n, int __flags, __SOCKADDR_ARG __addr, socklen_t *__restrict __addr_len); /* Put the current value for socket FD's option OPTNAME at protocol level LEVEL into OPTVAL (which is *OPTLEN bytes long), and set *OPTLEN to the value's actual length. Returns 0 on success, -1 for errors. */ extern int getsockopt (int __fd, int __level, int __optname, void *__restrict __optval, socklen_t *__restrict __optlen) __THROW;
I didn't pick up on this properly. You're building the last release GNet version (2.0.7) and not CVS it seems. I thought you were building GNet CVS for some reason. This should have been fixed ages ago (August 2005) in GNet CVS by this change: http://cvs.gnome.org/viewcvs/gnet/src/tcp.c?r1=1.67&r2=1.68 I will make a new release Really Soon Now ....