GNOME Bugzilla – Bug 322514
mouse capplet doesn't list the 'default' cursor theme
Last modified: 2007-02-13 16:57:42 UTC
Please describe the problem: The Mouse pref panel doesn't list the 'default' cursor theme (i.e. the xorg default, th one you would have on a fresh install before using this control panel). As a result, if you change the cursor to one you dislike and you preferred the default, you can't switch back to the default, even though it's in the same directory (/usr/share/cursors/xorg-x11/) as the other themes. Steps to reproduce: 1. On a fresh install of gnome/xorg, Go to G->Desktop->Prefs->Mouse 2. Go to the cursors tab 3. note your current pointer 4. change to one of the themes listed 5. try to revert to the previous theme Actual results: The 'default' (i.e. xorg default cursor) theme isn't listed, and thus this is impossible. Expected results: There should have been a listing for the 'default' theme. Does this happen every time? Yes Other information: workaround: use the configuration editor (G->System Tools->Configuration Editor) to change the value of /desktop/gnome/peripherals/mouse/cursor_theme to 'default' (sans quotes)
See also http://bugs.gentoo.org/show_bug.cgi?id=111930
Thanks for your bug
*** Bug 329436 has been marked as a duplicate of this bug. ***
Please execute 'locate cursor.theme' and tell us the location of the cursor theme that gets loaded by default. Thank you.
"locate cursor.theme" yields no results on my box.
Neither does it for me. I'm not sure if the default X.org cursor theme is even a file (i.e. I don't even have a /usr/share/cursors or similar).
I see two ways to fix it: 1. Always add the default theme without preview (this will look ugly and maybe users will claim that its broken). 2. Remove the preview code to make the dialog look more like the theme capplet. As we have instant-apply wihtin this dialog I think the preview is less important as users can see the results of their actions immediately. This way not having a preview for the default theme would suck less.
The problem with removing the preview (in contrast to the theme capplet) is that it's much more work to see what your pointer's going to look like. You will see the standard pointer, of course, but then you'll have to start dragging stuff around, resizing windows, etc. That's pretty bad. If it's not possible to create a preview of the built-in theme (no idea what the cursor API looks like) I'd still vote for option 1. Since you'd have to special-case the default theme anyway, you could just display a message explaining why there is no preview for it.
If it helps, the Cursor tab of XFCE's Mouse Preferences lists the "default" theme, but doesn't show a preview for it like it does for the others.
*** Bug 350594 has been marked as a duplicate of this bug. ***
from last duplicate
+ Trace 70191
The backtrace doesn't bring us forward since I still think that this g_return_*() statement is correct. Not correct is the fact that the default cursor theme is not displayed (which would - if fixed - also fix the runtime warning you guys are triggering). Patch welcome
*** Bug 351069 has been marked as a duplicate of this bug. ***
a mee-too style of comment, but a remark to the solutions stated in comment #7 Why not make it a button "reset to default" instead of adding it as an entry in the preview box or disabling preview altogether?
> Why not make it a button "reset to default" instead of adding it as an entry in > the preview box or disabling preview altogether? I actually have several problems with this proposal: 1. You're just changing the cursor theme, so why not do it the same way as we do for all the other themes? 2. How would you display "default theme selected" in your UI proposal? 3. Don't you think users would be confused by an empty list to choose from, plus a button that says "reset to default". I'd not take this dialog serious, being a user.
> 1. You're just changing the cursor theme, so why not do it the same way as we > do for all the other themes? ??? You're changing the cursor theme. Right. But currently this is a one-way. You cannot unod the change (apart from hacking gconf-settings). That's why this bug was filed. Other themes changed can be undone by simply choosing the previously used theme. This is not possible with the current dialog. > 2. How would you display "default theme selected" in your UI proposal? I would not display it. Why should it be displayed? It is plain ol' X. If you acciently reset to default and don't like it, just use one of the offered cursors again. As you wrote: Only chaning the cursor theme, so playing with the different curors offered is not a big deal. > 3. Don't you think users would be confused by an empty list to choose from, > plus a button that says "reset to default". Not at all. I'm confused by your comment. Why should the list to choose from be empty? > I'd not take this dialog serious, being a user. Being a user, I don't take dialogs serious that don't let me change back to default.
Created attachment 71020 [details] ugly mockup of the "reset"-button approach The button in the middle should reset the theme to X's default. No fancy other stuff required. Whether you put it in the bottom row or place it somewhere else is not relevant.
(In reply to comment #16) > > 3. Don't you think users would be confused by an empty list to choose from, > > plus a button that says "reset to default". > > Not at all. I'm confused by your comment. > Why should the list to choose from be empty? Because some people (like me) don't have any cursor themes installed. I'd rather have a "default" theme in the list, even if that doesn't offer a preview.
Well, the redglass, handheld and whiteglass I have come with XFree86 - so... But anyway: If there are no themes, then the dialog box should tell so: "No cursor themes installed" Instead of offering something to choose from/instead of offering "empty" choices at all. Whether you show or hide the reset button in that case or just disable it is again an implementation detail. And again: The main thing is to be able to switch to the default theme again after playing around with the cursor themes.[1] The Reset-button just was a proposal, since I really think that it is the wrong choice to disable the previews altogether. [1] one of the main reasons being that the new cursor is not applied everywhere - e.g. inside epiphany's body the cursor still is the default, whereas in the menu/toolbar area the themed one is used - but that's another story.
In reply to comment #18 > Because some people (like me) don't have any cursor themes installed. I'd > rather have a "default" theme in the list, even if that doesn't offer a > preview. Thanks Jens, I forgot that one. Christian, to cut a long story short: I start fixing this bug right now. And my fix will not include ANY reset button.
In reply to comment #19 > If there are no themes, then the dialog box should tell so: > > "No cursor themes installed" > > Instead of offering something to choose from/instead of offering "empty" > choices at all. Christian, this is wrong. As long as there is a default theme, there's no need to claim that no theme is installed. > And again: The main thing is to be able to switch to the default theme again > after playing around with the cursor themes.[1] ... which you can pretty easily do by just selecting your default cursor from a list. > [1] one of the main reasons being that the new cursor is not applied everywhere > - e.g. inside epiphany's body the cursor still is the default, whereas in the > menu/toolbar area the themed one is used - but that's another story. Right, IIRC this is a mozilla story that should be brought up at bugzilla.mozilla.com Just one line more: the default theme IS a theme, so there's no reason to claim there's no installed theme (which I would consider being a lie). As the default theme is a theme, why not treat it like all others (except for the preview thing, which has got technical reasons)?
In reply to comment #17: > Created an attachment (id=71020) [edit] > ugly mockup of the "reset"-button approach Putting the button into the button bar would make it available for the other tabs too. So this would actually confuse me if I modify the double click delay and "reset to defaults" doesn't seem to do anything but change my cursor theme.
Created attachment 71023 [details] [review] Proposed patch Proposed patch, created with -b so whitespace changes don't appear. Cleaning up the code a bit, added the default theme with a localized name (which is already used in the !XCursor case, so there's actually no new string)
thank you for the patch Sven, from a quick look it seems to be fine to me, feel free to commit!
2006-08-16 Sven Herzberg <herzi@gnome-de.org> * gnome-mouse-properties.c: also display the default theme (though without a preview for technical reasons); fixes bug #322514
Looks good here. Thanks Sven!
I would have expected that the default entry would be at the top of the list, not at the bottom - but apart from that I can confirm that it works here as well.
In reply to comment #27 > I would have expected that the default entry would be at the top of the list, > not at the bottom It does not appear at the bottom. It appears in alphabetical order.
Having it in alphabetical order is even less fortunate IMHO - but the main problem is fixed and that is what counts...
When I pick the Default-Pointer theme in gnome 2.16 I still have the industrial cursors. Does this work for anyone else?