After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 322239 - Fields in mail composer lose selection when window loses focus
Fields in mail composer lose selection when window loses focus
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.4.x (obsolete)
Other Linux
: Normal minor
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2005-11-23 14:43 UTC by James "Doc" Livingston
Modified: 2006-06-03 09:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
A partial fix. (3.25 KB, patch)
2006-05-20 11:27 UTC, Hiroyuki Ikezoe 		none Details | Review
update patch (4.10 KB, patch)
2006-05-20 13:24 UTC, Hiroyuki Ikezoe 		needs-work Details | Review
revised patch (5.63 KB, patch)
2006-06-01 06:34 UTC, Hiroyuki Ikezoe 		committed Details | Review

Description James "Doc" Livingston 2005-11-23 14:43:30 UTC 
When using the mail composer and you have selected the text in one of the fields
at the top (To, CC, BCC, etc. but not Subject), the selection is lost when the
window loses focus. This is most noticable when you select the address in the To
field, switch to another window and middle-click - it will not paste because the
selection has been lost.
Comment 1 Hiroyuki Ikezoe 2006-05-20 11:27:01 UTC 
Created attachment 65890 [details] [review]
A partial fix.

This patch is for eds.
Comment 2 Hiroyuki Ikezoe 2006-05-20 11:32:52 UTC 
The above patch is just effective in preserving selected text when focus-out.

When focus-in after focus-out, the selected text has gone. It is caused by composer/e-msg-composer.c. 

For this reason, to fix completely this bug needs more work.
Comment 3 Hiroyuki Ikezoe 2006-05-20 13:24:30 UTC 
Created attachment 65896 [details] [review]
update patch

My previous comment was wrong.

I managed to break down this bug only in eds.
Comment 4 Srinivasa Ragavan 2006-06-01 05:30:39 UTC 
hiroyuki, your patch looks fine, but it breaks ABI. I would suggest to add that variable to priv or as a g_object_set_data or so.
Comment 5 Hiroyuki Ikezoe 2006-06-01 06:03:33 UTC 
Thank you for your review. I will revise my patch with priv using 
g_type_class_add_private. I don't like g_object_get_data.
Comment 6 Hiroyuki Ikezoe 2006-06-01 06:34:15 UTC 
Created attachment 66575 [details] [review]
revised patch

Use priv structure with g_type_class_add_private for the sake of ABI compatibility.
The rest of code is the same as previous one.

I think whole code of e-name-selectory-entry should be rewrite using private structure when ABI broken allows.
Comment 7 Srinivasa Ragavan 2006-06-02 03:49:34 UTC 
looks fine to commit. Thanks for your patch.
Comment 8 Harish Krishnaswamy 2006-06-02 10:47:17 UTC 
Committed to HEAD.
Comment 9 Harish Krishnaswamy 2006-06-02 10:49:31 UTC 
sorry..forgot to resolve the bug.
Comment 10 André Klapper 2006-06-03 09:04:39 UTC 
(message to myself when i'm back at my own computer:)
should check if this has an impact on bug 339098 and bug 207728
Comment 11 Hiroyuki Ikezoe 2006-06-03 09:43:02 UTC 
bug 339098 is the same one, but I do not think bug 207728 is the same one. That is another issue.