GNOME Bugzilla – Bug 322105
Allow non-junk training on non-junk messages
Last modified: 2013-09-10 14:04:48 UTC
Some junk filter implementations (e.g. bogofilter) rely on non-junk training to function properly. It's not possible in Evolution, as of 1.4.x, to train the junk plugin on the messages which aren't labeled as junk first. There is a Spam Trainer GUI tool (http://spamtrainer.sourceforge.net/) with which one can facilitate training using drag-n-drop from Evolution. Still, it's an external application.
sorry, is this 1.4.x (as in your report) or 2.4.x (as in your version number)? works perfectly here, i go to my spam folder and can unmark messages as spam, at least with spamassassin. running 2.5.2-unstable here. i know that you've coded the bogofilter-plugin, that's why i asked. you're missing a hook? because it works for spamassassin. i'm not a coder though, but i don't get it. :-)
Sorry, I did mean 2.4.x. > works perfectly here, i go to my spam folder and can unmark messages as spam, at least with spamassassin. running 2.5.2-unstable here. Didn't check with 2.5.2 yet, but in 2.4.1, "mark as non-spam" command doesn't do anything on _non-spam_ messages. Which is what I need to give initial traning to bogofilter.
*Mark* non-Junk mails as not being Junk. Aka *LEARN* this message as not being Junk. This is an important missing feature. A way to actually train your Bayes database. Raising priority. This is easy to implement: * Make buttons be visible and sensitive always. * Marking as not-Junk using the UI *always* has to pass the mail to sa-learn, *regardless* if it was Junk or not Junk before. Same for the Mark as Junk button. Enable the user to train his Bayes. Make Bayes actually useful.
I have been seen the code of the evolution plugins. I think that it can be solved easily by adding the "-u" option to the function "em_junk_bf_check_junk". So, bogofilter can learn while it is deciding about ham or spam. I didn't tried it, but I have put the "bogofilter -u" filter for all messages and it learn faster (but it learn twice for spams :D). I hope to help.
(In reply to comment #4) > I didn't tried it, but I have put the "bogofilter -u" filter for all messages > and it learn faster (but it learn twice for spams :D). The suggested feature is not meant specifically for the bogofilter plugin. Then, the bogofilter -u mode is more dangerous than training on errors only, because it can reinforce false positives for an unsuspecting user. Anyway, the bogofilter plugin is not in the Evolution source tree, so further discussion specific to it is probably irrelevant to this bug.
Created attachment 85158 [details] [review] Camel Patch
Created attachment 85159 [details] [review] Evolution portion of patch.
These two patches enable the NOTJUNK button in all folders. Also click that will make JUNK plugin learn as HAM. I have tested it with SA. Im looking into taking bogo as part of the main source tree. If both BOGO and SA are enabled, then in the mail preferences/JUNK tab, the user can choose which SPAM plugin he wants to use. Mikhail I assume that this is the place to look for the plugin. http://people.altlinux.ru/~mhz/software/projects/bf-eplugin/bf-eplugin-0.2.0.tar.gz Also let me know, if these patches works for you. I should be done for 2.11.1 if things go easy.
(In reply to comment #8) > Im looking into taking bogo as part of the main source tree. If both BOGO and > SA are enabled, then in the mail preferences/JUNK tab, the user can choose > which SPAM plugin he wants to use. > > Mikhail I assume that this is the place to look for the plugin. > > http://people.altlinux.ru/~mhz/software/projects/bf-eplugin/bf-eplugin-0.2.0.tar.gz Correct. I also posted a patch at some point for inclusion of the plugin in the Evolution tree, but it may be outdated and I don't have time for bringing it in sync. > Also let me know, if these patches works for you. I should be done for 2.11.1 > if things go easy. Sorry, can't check at the moment...
(In reply to comment #9) > (In reply to comment #8) > > Im looking into taking bogo as part of the main source tree. If both BOGO and > > SA are enabled, then in the mail preferences/JUNK tab, the user can choose > > which SPAM plugin he wants to use. > > > > Mikhail I assume that this is the place to look for the plugin. > > > > http://people.altlinux.ru/~mhz/software/projects/bf-eplugin/bf-eplugin-0.2.0.tar.gz > > Correct. I also posted a patch at some point for inclusion of the plugin in the > Evolution tree, but it may be outdated and I don't have time for bringing it in > sync. You posted to e-p list? Do you have the link to your old patch > > > Also let me know, if these patches works for you. I should be done for 2.11.1 > > if things go easy. > > Sorry, can't check at the moment... >
(In reply to comment #10) > You posted to e-p list? Do you have the link to your old patch Found it here: http://mail.gnome.org/archives/evolution-hackers/2005-December/msg00063.html This is version 0.1-ish, so you might have to update it with the latest standalone source. Good as a starting point for integration though...
Also, check out the Evolution package in Ubuntu, they've taken my patch and went with it for their subsequent releases, so it must be more upstreamable against recent development.
Fixed.
Hmmm... In which version was it fixed ?
It was fixed in 2.12.