GNOME Bugzilla – Bug 321607
podcast status column
Last modified: 2018-05-24 10:53:06 UTC
I think there are a few problems with the podcast status column. * It uses a fixed width column but includes text. This doesn't work. We should either not use a fixed width or not use text. * The use of the term "Paused" is very confusing since we also use that term as a playback state. It is also misleading when it is used to mean something like not ready to play. * When a track is downloaded and ready to play there is no need to have an ugly progress bar with the work Completed in it. * The column heading is misleading because it doesn't indicate that it really means "Download Status". * Why should we display a "Failed" message when we already have an error icon available. So, what might be better? How about replacing the column with one that has an icon for: * Download / Get * Downloading * Error * Delete The delete will only appear when the file has downloaded. It might be nice to have the tree row look dimmer when the file isn't ready to play.
I guess we could replace the "now playing" column with a special status one. The following states exist, with my suggestions: Undownloaded: no icon Queued: some icon Downloading: some icon, percentage as tooltip Downloaded: some icon, Download Error: error icon Playing: use normal playing icon Play Error: use normal play error icon, with message on click I can't find any decent icons for queued, downloading and downloaded amongst the stock icons - so we might have to add some of our own.
Sounds good to me. Don't think we'll be able to do the tooltip though.
I've changed the "Paused" status to "Undownloaded" and "Completed" to "Downloaded". The other issues still want improving.
I'm not sure "Undownloaded" is a good word to use. Making the column completely blank by setting "visible" to FALSE on the cell renderer (so you don't even get the progress bar outline) seems to work OK. It'd be nicer if the progress bar was only shown while actually downloading, but it looks like we can't do that without writing a custom cell renderer. I think that as long as it's clear which episodes have been downloaded (and using "downloaded" as the status text certainly does that), and interaction with non-downloaded episodes makes sense, we don't need to explicitly state that an episode has not been downloaded. Perhaps I'm thinking about this backwards, though, since I don't tend to download every episode of the few podcasts I subscribe to.
That sounds like a better way of doing it. Do we want to change it for 0.9.3, or leave it until after?
Created attachment 58313 [details] [review] leave status column blank for undownloaded episodes Here's a patch, in any case. I personally think this is better than using "Undownloaded", but I'd like to see what other people think.
I think it looks much nicer. Not having the progress bar for things other that downloading would be better but, as you pointed out, we would need a custom cell renderer.
*** Bug 329678 has been marked as a duplicate of this bug. ***
The patch looks fine to commit if you want to.
Committed. There's still more to do on this, so I'm leaving the bug open.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/rhythmbox/issues/88.