GNOME Bugzilla – Bug 321436
Detect FAT filesystem and enable strip special chars by default
Last modified: 2008-01-02 21:25:03 UTC
Please describe the problem: If the title of a track contains a colon or a question mark, SJ will freeze when it starts to rip that track. It will stay frozen for hours or days or until it receives a force-quit. Removing the offending punctuation mark from the title causes the rip to proceed normally. Steps to reproduce: 1. Try to rip a CD where a track name contains a colon or question mark. 2. Watch it freeze when it gets to that track. 3. Remove question mark or change colon to a dash and watch it rip normally. Actual results: Expected results: Does this happen every time? Yes Other information: Sound Juicer also tends to behave badly if there are question marks or colons in the album title or artist. I'm using Ubuntu Linux if that helps.
Also: The target format is FLAC.
Are you writing to a FAT or ext3 filesystem? If you are writing to FAT, you need to select "Strip Special Characters". Really I should find a way of auto-detecting this.
Setting to NEEDINFO.
Sorry, I didn't notice your comments from 11/15 because the email notification got lost in all the spam... The FLAC files are being saved on a vfat partition. I'll try "strip special characters" next time I rip a CD.
The exact same problem still exist with sound-juicer 2.16.1. The difference is that now sound-juicer crash with a segfault. More info here : https://launchpad.net/products/sound-juicer/+bug/72218
gnome_vfs_volume_get_filesystem_type() can be used to determine what file system it is being saved to, it's just need a map of what characters are illegal on various file systems.
Backtrace of the crash with 2.16.1: (sound-juicer:9705): GLib-CRITICAL **: g_source_remove: assertion `tag > 0' failed Program received signal SIGSEGV, Segmentation fault.
+ Trace 89245
Thread NaN (LWP 9705)
This should probably go in libjuicer.
*** Bug 474255 has been marked as a duplicate of this bug. ***
#474255 is about writing to a NTFS file system, where multibyte characters need special treatment.
Sorry for not being able to contribute to the fixing of this bug, except by telling you that it is still there in my sound juicer version (2.20.0, from the ubuntu repos, installed on a xubuntu 7.10) i had the problem with a fat32 file system and the colon : by the way, bash and thunar have somehow the same problem: they cannot copy files with : or ? to a fat32 file system. bash says: "gnome_vfs_volume_get_filesystem_type()" however, bash and thunar give an error message instead of crashing. maybe you can make use of the mechanisms they are using? or maybe there people are working on a real solution there and you can use synergies? Good luck and thanks for the nice application!
For anyone who decides to look at this: there is magic in sj-extracting.c to strip special characters, this needs to be extended to take a file system type and add in a set of characters which are not allowed for that file system.
*** Bug 414859 has been marked as a duplicate of this bug. ***
*** Bug 505072 has been marked as a duplicate of this bug. ***
Note that this is being worked on by a GHOP participant.
Fixed in svn, thanks Carl-Anton and GHOP.
If writing to a vfat file system is the cause (as suggested by Christophe) this will also fix bug #380727.
*** Bug 380727 has been marked as a duplicate of this bug. ***
*** Bug 455433 has been marked as a duplicate of this bug. ***