GNOME Bugzilla – Bug 321155
Panel Back ground file selector should have preview option
Last modified: 2005-12-17 11:08:02 UTC
Please describe the problem: 1) Right click on panel -> Properties -> Background tab 2) Set 'Background image' radio button. 3) Click the browse button. Observe that the image file selector dialog does not have the preview pane on the right side. Since its image selection opening gtk file chooser/selector should be opened preview option. Its done in back ground capplet. Steps to reproduce: 1. 2. 3. Actual results: Expected results: Does this happen every time? Other information:
2005-12-15 Vincent Untz <vuntz@gnome.org> Add a preview widget in the image background chooser. Fix bug #321155. * panel-properties-dialog.c: (panel_properties_dialog_chooser_preview_update): new (panel_properties_dialog_setup_image_chooser): connect stuff to update the preview widget
Vincent, was working out a patch for this bug, you seem to beat me to it :) Just checked out the latest code and found some test cases did not pass through. Have listed them below, When user has already set his background image and wants to change it - Clicking on the file-chooser button will not show the preview of the current background image of the panel. - When user browses through the list and selects another image file (eg: try1.png) in the file chooser, the preview is seen. Now if the user Cancels the filechooser dialog and again opens the filechooser dialog, the preview of the last image which had the selection and was cancelled is seen (ie try1.png) though its not the actual panel background image. Attaching the patch I had worked upon. Probably if you agree on the validity of the test cases above we could work out the differential patch that could get in. Please have a look at the attached patch.
Created attachment 56071 [details] [review] Proposed Patch
Srirama: the bugs you describe are GtkFileChooserButton bugs. We won't workaround them in the panel. See eg bug 319525