GNOME Bugzilla – Bug 320559
libpanel-applet abi breakage
Last modified: 2005-11-03 12:22:00 UTC
2005-10-24 Vincent Untz <vuntz@gnome.org> * drawer.c: add FIXME * launcher.c: (drag_data_get_cb): fix warning (panel_launcher_set_dnd_enabled): add FIXME * menu.c: (icon_theme_changed): don't use GnomeIconTheme * panel-applet-frame.c: (panel_applet_frame_change_orientation): I'm not sure why the orientation were inverted, but I think it's a bug. So fix it. It might break things, though... ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ (panel_applet_frame_get_orient_string): ditto * panel-properties-dialog.c: add TODO * panel-run-dialog.c: (entry_drag_data_received): use g_uri_list_extract_uris() and remove warning (pixmap_drag_data_get): remove warning This causes bug #320554. Please revert. It's ABI/API breakage. Just document it correctly, what you're doing here is not the right way.
I've thought about it before committing the patch, and I decided it was okay. Note that libpanel-applet is not in the developer platform (AFAIK). Also, I sent a mail to Davyd with a patch for gnome-applets (maybe he didn't apply it?) and I verified all the applets that are in GNOME. We could revert the patch (and I'm considering the option), but I believe it's okay to do it now, at the beginning of a development cycle.
Created attachment 54267 [details] [review] Patch for gnome-applets This is the patch I sent to Davyd on October 24th.
It is actually documented: The #PanelAppletOrient type specifies the orientation of the applet. The values may seem backward (e.g. %PANEL_APPLET_ORIENT_LEFT means the panel is on the right hand side), but this is because the value is representative of the applet's <emphasis>orientation</emphasis>, not the panel's position. <!-- ##### MACRO PANEL_APPLET_ORIENT_UP ##### --> The applet is orientated up (i.e. the panel is at the bottom of the screen). <!-- ##### MACRO PANEL_APPLET_ORIENT_DOWN ##### --> The applet is orientated down (i.e. the panel is at the top of the screen). <!-- ##### MACRO PANEL_APPLET_ORIENT_LEFT ##### --> The applet is orientated left (i.e. the panel is at the right hand side of the screen). <!-- ##### MACRO PANEL_APPLET_ORIENT_RIGHT ##### --> The applet is orientated right (i.e. the panel is at the left hand side of the screen). And its been like this since GNOME 1.x days AFAIR. Its silly to change this now, IMHO. If we were designing a whole new applet API, it might make sense, but otherwise it seems like pointless breakage. Especially since its the first time that the API/ABI has been broken since GNOME 2.0. (And if we were making the change I'd probably go for some thing like: typedef { PANEL_APPLET_POSITION_TOP, PANEL_APPLET_POSITION_BOTTOM, PANEL_APPLET_POSITION_LEFT, PANEL_APPLET_POSITION_RIGHT } PanelAppletPosition; )
Oh, I hadn't seen it's documented. I reverted this. And I think I'll start a new applet library soon ;-)