After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 320542 - [PATCH] add slideshow in single image mode
[PATCH] add slideshow in single image mode
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: image viewer
git master
Other Linux
: Normal normal
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-11-02 19:31 UTC by Emmanuel Touzery
Modified: 2005-11-13 18:27 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14


Attachments
this patch adds the new feature. it's against CVS HEAD of nov2 2005 (3.61 KB, patch)
2005-11-02 19:32 UTC, Emmanuel Touzery
none Details | Review
better patch (3.11 KB, patch)
2005-11-02 19:44 UTC, Emmanuel Touzery
none Details | Review

Description Emmanuel Touzery 2005-11-02 19:31:55 UTC
I'll attach to this bug a patch again GNOME anoncvs as of nov2 2005 to add to
EOG slideshow of images even when opening a single image (file->open as opposed
to file->open folder).
Just open a single image, view->slideshow is activated and displays a slideshow
of all the images in the folder.

Tell me if you want changes to the patch.
Comment 1 Emmanuel Touzery 2005-11-02 19:32:50 UTC
Created attachment 54244 [details] [review]
this patch adds the new feature. it's against CVS HEAD of nov2 2005
Comment 2 Emmanuel Touzery 2005-11-02 19:44:51 UTC
Created attachment 54245 [details] [review]
better patch

I realised the previous patch did not free some resources. I'm programming too
much in C#... better now.
Comment 3 Lucas Rocha 2005-11-03 04:27:24 UTC
Thanks for the patch! I think this feature will be present when we move EOG to
the new UI that we're planning for 2.14 (see http://live.gnome.org/EyeOfGnome).
For now, this feature would be not intuitive because of the current UI aproach.
Comment 4 Emmanuel Touzery 2005-11-03 07:16:41 UTC
nice to see new plans for EOG. However, I see that patch as part of this plan.
The only other parts of this plan is to remove the directory view, add
previous/next in the toolbar and remove new. Probably this new UI would not
require a rewrite? This patch could be step 1 of this new plan.

I don't see why this feature is not intuitive at this stage. The feature does
not depend on the directory view. On the GUI view it seems identical to what is
detailed in the plan. As part of EOG 2.14 you can just remove the directory view
it will not affect this?

I would just like to be sure that in 2.14 it will actually be possible to view a
slideshow without being in directory mode because i view that as a critical
feature. And I don't see this patch conflicting with the plan, only supporting it.
Comment 5 Emmanuel Touzery 2005-11-03 10:48:32 UTC
Ah, maybe I understand what you meant: that you'd like to merge full screen and
slideshow, only offering fullscreen in the GUI, with fullscreen having a
floating toolbar and a play button to press to get a slideshow.

Is it what you want/why you don't want this change?
Comment 6 Lucas Rocha 2005-11-03 10:57:24 UTC
No, it's more simple than that. :-) First, I'd like to add Next/Prev button and
remove directory view because it'd make the user "aware" that when (s)he's
viewing a single image, (s)he can navigate through other images from the same
directory. This way, It'd would be more intuitive that the slideshow work as you
propose here.

Don't worry, this feature is part of the 2.14 plan. :-)
Comment 7 Lucas Rocha 2005-11-13 18:27:20 UTC
Fixed in HEAD. With the new UI, when you open a single image, you can easily
browse images from the same directory. So, slideshow behaves as suggested here.