After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 320074 - black dots in load applet
black dots in load applet
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: multiload
2.12.x
Other All
: Normal trivial
: ---
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-10-28 12:08 UTC by Bas Zoetekouw
Modified: 2010-01-24 01:06 UTC
See Also:
GNOME target: ---
GNOME version: 2.11/2.12


Attachments
screenshot showing the problem (1.62 KB, image/png)
2005-10-28 12:10 UTC, Bas Zoetekouw
  Details
proposed patch for rounding errors (1.29 KB, patch)
2005-10-28 12:13 UTC, Bas Zoetekouw
none Details | Review
updated patch for rounding errors (825 bytes, patch)
2005-10-28 12:26 UTC, Bas Zoetekouw
accepted-commit_now Details | Review

Description Bas Zoetekouw 2005-10-28 12:08:18 UTC
Please describe the problem:
Randomly, the topmost pixel of the load graph is not drawn (and thus stays
black).  Normally, this isn't visible as the the color for "Idle" cpu time is
also set to black.

This is caused by rounding errors in linux-proc.c.  

I'll attach a screenshot and a patch.

Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Bas Zoetekouw 2005-10-28 12:10:21 UTC
Created attachment 53990 [details]
screenshot showing the problem
Comment 2 Bas Zoetekouw 2005-10-28 12:13:32 UTC
Created attachment 53991 [details] [review]
proposed patch for rounding errors
Comment 3 Bas Zoetekouw 2005-10-28 12:26:20 UTC
Created attachment 53992 [details] [review]
updated patch for rounding errors

Oops, attached the wrong patch before.	This one should be ok.
Comment 4 Benoît Dejean 2006-01-02 16:08:43 UTC
Looks fine.
Comment 5 Danielle Madeley 2006-01-06 03:45:27 UTC
This should be committed to HEAD.
Comment 6 Kjartan Maraas 2006-01-08 16:04:17 UTC
I commited this.