After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 319689 - eject/mounting a video DVD several times creates new DVD drives on a pure HAL/PMOUNT system.
eject/mounting a video DVD several times creates new DVD drives on a pure HAL...
Status: RESOLVED FIXED
Product: gnome-vfs
Classification: Deprecated
Component: Async operations
2.12.x
Other Linux
: Normal major
: ---
Assigned To: gnome-vfs maintainers
gnome-vfs maintainers
: 158672 (view as bug list)
Depends on:
Blocks: 318401
 
 
Reported: 2005-10-25 00:27 UTC by Sylvain BERTRAND
Modified: 2006-07-14 18:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.11/2.12

Attachments
Fix problems of ghost cdrom/dvdrom drives showing up (1.47 KB, patch)
2005-10-27 14:08 UTC, Jon Nettleton 		none Details | Review
Slight placement modification of the previous patch (1.47 KB, patch)
2005-10-30 20:34 UTC, Jon Nettleton 		none Details | Review
Don't treat temp udi's as real volumes (1.37 KB, patch)
2005-11-04 12:34 UTC, Jon Nettleton 		none Details | Review

Description Sylvain BERTRAND 2005-10-25 00:27:18 UTC 
Version details: gnome-vfs 2.12.1.1
Distribution/Version: Gentoo 2005.1

dbus 0.36.2, HAL 0.5.4, pmount 0.9.3, no entry in fstab for my DVD drive.
1 - Open the computer window.
2 - Click on eject in the DVD drive icon contextual menu.
3 - Insert a video DVD in the tray.
4 - Click on mount in the DVD drive icon contextual menu.
5 - eject from the mounted video DVD icon.
6 - mount from the DVD drive icon...
...
until a mounted video DVD icon appears, in addition to the DVD drive icon! Then
eject from the mounted video DVD icon and start over.
You can create as many DVD drives you want this way (it screws everything up,
making totem crash for instance).
Comment 1 Jon Nettleton 2005-10-27 14:08:25 UTC 
Created attachment 53947 [details] [review]
Fix problems of ghost cdrom/dvdrom drives showing up

temp udl's were being passed to the volume_mount code.	This would cause the
drive without volumes object to be destroyed and a new one created as a drive
with volume's.	Once the volume was actually mounted volume_mount would be
called again with the new volume udi, which would cause the drive to be created
again before attaching the volume.  Hal's temp udi is for internal usage so
this code bails out of the mount if it string matches that for the volume.
Comment 2 Sylvain BERTRAND 2005-10-27 20:32:17 UTC 
After using this patch, I was not able to reproduce the bug.
Comment 3 Jon Nettleton 2005-10-30 20:34:03 UTC 
Created attachment 54101 [details] [review]
Slight placement modification of the previous patch

I was a bit over zealous in my previous exit.  Some other drives and volumes
weren't getting removed from monitoring properly because of it.
Comment 4 Sylvain BERTRAND 2005-11-01 18:01:17 UTC 
I have no issue to report with this new patch.
Comment 5 Alexander Larsson 2005-11-04 08:42:08 UTC 
I don't really know how the HAL stuff works, but this looks ok and people tested
it, so I'm commiting this.

However, the two patches you attached are identical, so maybe you forgot to
attach the right patch the second time?
Comment 6 Jon Nettleton 2005-11-04 12:34:57 UTC 
Created attachment 54312 [details] [review]
Don't treat temp udi's as real volumes

I attached the wrong version of the patch last time.  This is the final
placement fix that doesn't bail out before volumes are removed on ejection. 
Sorry.
Comment 7 Alexander Larsson 2005-11-07 08:08:21 UTC 
Commited. Thanks.
Comment 8 Christian Neumair 2006-07-14 18:47:43 UTC 
*** Bug 158672 has been marked as a duplicate of this bug. ***