Created attachment 53593 [details] [review]
patch for hypertext support

It looks quite good so far, but:

- Hypertext.getLink() doesn't raise an AtspiException. It doesn't really *have*
to, but it should only say it does if it in fact does.
- Hypertext.getNLinks() needs to be bound.

In general though, Hypertext support doesn't really give us much without
Hyperlink support. I did read that you're planning on implementing that -
if/when you do, just add it to this patch as opposed to opening a separate bug.

Thanks!

Thanks for the indications, attaching another patch, more complete.
It does have a problem somewhere: with this patch pyspi compiles ok, but after
installing it won't be recognized by "import pyspi":
ImportError: Error importing the AT-SPI bindings

Please advise

Created attachment 53624 [details] [review]
hypertext and hyperlink objects bindings

Sorry for taking so long to reply.

The patch currently doesn't work:

t a>>> import atspi
Traceback (most recent call last):

+ Trace 63883

'grep Accessible_getHyperlink /usr/include/at-spi-1.0/cspi/*' returns nothing,
so I'm guessing that function doesn't actually exist.

I'm in the process of rewriting your patch. I'll attach what I have so far.

Created attachment 54295 [details] [review]
hyper* bindings

Hi Zack,

Looks good to me. Could you please commit it? We can make small modifications
later if required. The real test will be with dogtail having hyper* objects
support too.

Created attachment 54594 [details] [review]
hyper* patch

Here's what I just committed. It may need more work, but for now I think it's
OK. Getting all this into dogtail might be pretty hard, though.

Thanks, Marius.