After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 319041 - SVG icons for HighContrast icon theme
SVG icons for HighContrast icon theme
Status: RESOLVED FIXED
Product: gnome-themes
Classification: Deprecated
Component: theme-highcontrast
HEAD
Other All
: Normal enhancement
: ---
Assigned To: Calum Benson
Calum Benson
AP4
Depends on:
Blocks:
 
 
Reported: 2005-10-17 07:43 UTC by Luca Ferretti
Modified: 2006-05-04 22:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
The icons! (34.05 KB, application/x-compressed-tar)
2005-10-17 07:45 UTC, Luca Ferretti
Details
Updated theme set using emerging fd.o icon-naming standard (61.89 KB, application/x-gzip)
2006-02-07 08:23 UTC, Luca Ferretti
Details
documen-print icon in Inkscape with grids (20.50 KB, image/png)
2006-02-15 13:09 UTC, Luca Ferretti
Details
the same document-print icon at "runtime" zoomed with xmag (6.03 KB, image/png)
2006-02-15 13:14 UTC, Luca Ferretti
Details
blackwhite-icon-theme-0.0.2.tar.gz (198.21 KB, application/x-compressed-tar)
2006-04-06 13:00 UTC, Luca Ferretti
Details

Description Luca Ferretti 2005-10-17 07:43:31 UTC
This is a "placeholder" for misc stuff needed to port HighContrast icon theme to
SVG format. More detail on gnome-theme-list.
Comment 1 Luca Ferretti 2005-10-17 07:45:50 UTC
Created attachment 53571 [details]
The icons!

Here is available icons in SVG format, packed as icon theme. See README file
for detail. A patch will come to merge in gnome-themes package. Just waiting
for comments on themes mailing list.
Comment 2 Luca Ferretti 2005-10-17 08:39:08 UTC
http://mail.gnome.org/archives/gnome-themes-list/2005-October/msg00000.html

Here is the message on theme list
Comment 3 Calum Benson 2005-10-17 11:02:57 UTC
Adding accessibility keyword, and setting accessibility priority to 4 ("nice-to-have").
Comment 4 Luca Ferretti 2006-02-07 08:23:21 UTC
Created attachment 58844 [details]
Updated theme set using emerging fd.o icon-naming standard

Updated version of icon theme. Relevant changes are
  * Added some icons from myself (shape based on common guidelines and
    current PNG theme)
  * Icons renamed to match fd.o icon naming standard
  * Used icon-naming-utils to provide fallback named icons
  * Added (but non installed) a GTK+ Black-and-White theme (basically it's
    HighContrastLargePrint without icons)

Of course this means that you have to run autogen.sh/make/make install in order to use the theme.

TODO (a lot):
   * Finish the theme set :-)
   * Port all icons from points to pixels (you can control the appearance at
     runtime)
   * Change all borders from 3.5 to 3 (no more unuseful grayscale blending)
   * Write a python/perl/??? script to switch black and white and intall as
     -Inverse theme
Comment 5 Luca Ferretti 2006-02-10 12:07:56 UTC
Do'h :-( 

It seems that HIG suggests to use "all lines and borders at least 4 pixels wide"...

http://developer.gnome.org/projects/gup/hig/draft_hig_new/icons-design-accessible.html
Comment 6 Calum Benson 2006-02-15 11:43:18 UTC
All the original SVG high contrast icons should meet this criterion anyway... are there some that don't, or is this just for new ones you've added yourself?
Comment 7 Luca Ferretti 2006-02-15 13:04:29 UTC
I applied 3 pixels borders on changed and/or added icons. I was following the jimmac's tutorial, where was declared 3.5 width: due to unuseful and ugly antialing effects when the extra .5 was "rasted", I decreased to 3 pixels width.

The original SVGs seems to have 4 extern border, but sometimes it's not well aligned to grid (--> antialising effects). See next attachment.

Revert this mistake is really simple: just open object stroke and fill properties, increase stroke and check if it's well aligned.

I'll do it quickly

PS note that original SVG are using points are default size, while pixels seems better for "pixel-perfection".
Comment 8 Luca Ferretti 2006-02-15 13:09:05 UTC
Created attachment 59406 [details]
documen-print icon in Inkscape with grids
Comment 9 Luca Ferretti 2006-02-15 13:14:09 UTC
Created attachment 59407 [details]
the same document-print icon at "runtime" zoomed with xmag

Please note the "antialiasing" effects on paper borders and on horizontal lines in paper. Those effects are not a feature, but a bug.

So we should
  * use stroke/sizes for SVG object rouded to unit (4 pixels)
  * align SVG objects borders to grid
Comment 10 Luca Ferretti 2006-04-06 13:00:15 UTC
Created attachment 62850 [details]
blackwhite-icon-theme-0.0.2.tar.gz

New version of theme set. All info in NEWS and ChangeLog files inside it.


PS Maybe I should import it in CVS?
Comment 11 Calum Benson 2006-04-06 14:50:55 UTC
Cool... I'll try and have a look at this in the next few days, but in the meantime, yes, a patch would be appreciated :)
Comment 12 Jakub Steiner 2006-04-06 14:55:11 UTC
Good job Luca. Thanks for the work.

I'm definitely for putting it in g-t HEAD. We could branch the current state if we don't manage to get at least the same coverage as the current HighContrast before 2.16.
Comment 13 Calum Benson 2006-04-24 16:36:24 UTC
Okay, I've added the icons to CVS, so they'll be in the 2.15.1 tarball.  I made two slight changes without asking Luca first (it was a last-minute decision!), which are:

- changed the name to HighContrast-SVG
- made it inherit from HighContrastLargePrint before gnome

We can always change those things in later releases, I just wanted to get them in :)  I didn't bother doing any icon-naming-utils magic or anything either, so at the moment when you select the theme, not very much appears to happen because most apps (on my desktop at least) aren't using the fdo naming spec yet.

One other point... the theme is currently GPL'ed, whereas the rest of gnome-themes is currently LGPL (although Thomas is looking into alternatives).  It would be nice if all the themes in the same module had the same licence.
Comment 14 Calum Benson 2006-04-24 17:03:36 UTC
(Correction: for "not very much appears to happen" read "PNGs from HighContrastLargePrint are used instead"... that's why I changed the inheritance path, for now at least.)
Comment 15 Calum Benson 2006-04-26 17:09:35 UTC
Apologies for spam... ensuring Sun a11y folks are cc'ed on all current accessibility bugs.
Comment 16 Luca Ferretti 2006-04-27 07:29:28 UTC
(In reply to comment #13)
> Okay, I've added the icons to CVS, so they'll be in the 2.15.1 tarball.  I made
> two slight changes without asking Luca first (it was a last-minute decision!),
> which are:
> 
> - changed the name to HighContrast-SVG
> - made it inherit from HighContrastLargePrint before gnome

OK for me. The name was just a name...

> We can always change those things in later releases, I just wanted to get them
> in :)  I didn't bother doing any icon-naming-utils magic or anything either, so
> at the moment when you select the theme, not very much appears to happen
> because most apps (on my desktop at least) aren't using the fdo naming spec
> yet.

I'll try to add i-n-u stuff in the next days (legacy!). I suppose we don't need any svg2png conversion, isn't it?

BTW can I commit new/changed icons directly on CVS?

> One other point... the theme is currently GPL'ed, whereas the rest of
> gnome-themes is currently LGPL (although Thomas is looking into alternatives). 
> It would be nice if all the themes in the same module had the same licence.
> 

OK for me. Jakub?
Comment 17 Jakub Steiner 2006-04-27 17:58:02 UTC
It may have been LGPL right from the start. Pardon, pardon. I don't mind
shipping it under the terms of either LGPL or GPL.
Comment 18 Calum Benson 2006-05-04 22:53:10 UTC
Ok, I've just removed the HighContrast-SVG specific COPYING file, so the whole module is under LGPL again.  I've also committed the i-n-u stuff; I've made it a soft dependency rather than a requirement, so if you don't have i-n-u installed, it just won't bother doing the symlinks, and you'll have a "pure" fd.o theme.

@Luca: yes, please go ahead and commit any new HighContrast-SVG icons/build/bug fixes to CVS.  If you'd like to create and maintain a HighContrastInverse-SVG theme at the same time, feel free :)  (We'll have to do it at some point, but maybe it can wait until things are a bit more stable.)

I'm going to close out this bug now and create a new subcategory for any bugs relating to the HighContrast-SVG theme.  Good work!