After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 318592 - Please Allow UI Notification Of Links Inserted in Entry Mode
Please Allow UI Notification Of Links Inserted in Entry Mode
Status: RESOLVED FIXED
Product: GtkHtml
Classification: Other
Component: Editing
3.8.x
Other All
: Normal minor
: Future
Assigned To: Milan Crha
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2005-10-11 17:11 UTC by David Richards
Modified: 2007-11-01 13:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed gtkhtml patch (6.76 KB, patch)
2007-10-12 08:39 UTC, Milan Crha
committed Details | Review
proposed evo patch (2.58 KB, patch)
2007-10-12 08:46 UTC, Milan Crha
committed Details | Review

Description David Richards 2005-10-11 17:11:44 UTC
This issue is mostly happening for me in Evolution when composing email.  I
think this is the right place to put this issue.  When you insert a link into
the composer it shows up in Blue.  However, there is no UI way to ensure that
the link is correct once it's added.  I sometimes send out links to like file://
to people or other links, and want to QA it one last time before I send it out. 

In my view two things could happen to allow the person composing to make sure
the link is working and correct:

1) Allow a mouse over, so that the information of the link displays at the bottom.

2) Even better would be if you could click on the link and have it launch the
appropriate application.  This would exactly simulate the way it works after is
sent.

Right now I always mail these types of messages only to myself, and then make
sure it works, and then copy and paste it into the "real" message.  These UI
improvements would allow me to eliminate a step.

Other information:
Comment 1 André Klapper 2005-10-11 20:21:03 UTC
if bugzilla would support this, i would vote for it.
Comment 2 Milan Crha 2007-10-12 08:39:37 UTC
Created attachment 97105 [details] [review]
proposed gtkhtml patch

for gtkhtml;

Added support for clickable links also when in editable mode. It is enough to hold Control key to let this work.
Comment 3 Milan Crha 2007-10-12 08:46:34 UTC
Created attachment 97106 [details] [review]
proposed evo patch

for evolution;

evolution's part for this patch. It will pass all urls to gnome_url_show, except of "mailto:", "thismessage:" and "cid:" protocols.
Comment 4 Srinivasa Ragavan 2007-11-01 11:27:23 UTC
looks fine milan. Commit to head.
Comment 5 Srinivasa Ragavan 2007-11-01 11:29:55 UTC
Hmm, I think one hunk in gtkhtml failed. (I fixed while testing) Just take care of that as well.
Comment 6 Milan Crha 2007-11-01 13:37:36 UTC
gtkhtml part committed to trunk. Committed revision 8610.
evo part committed to trunk. Committed revision 34477.