GNOME Bugzilla – Bug 318042
Untranslated strings in image/graph popup menu
Last modified: 2011-09-30 19:23:42 UTC
Right clicking over a graph and/or image, "_Save ad image" and "_Order" menu items as well as all items in "_Order" submenu don't appears translated. But messages are in PO. Oh, same for the file type combobox in Save dialog
Created attachment 53075 [details] [review] fixes the object popup menu problem
May be we should turn to action based menus for contextual menus as well.
I can't confirm about the save dialog, it seems translated for me.
Created attachment 53090 [details] A screenshot showing the save dialog This is my desktop, with the used PO file (on left) and the Gnumeric "save image" dialog in it_IT locale. Dropdown entries are untranslated, while messages are, translated, in PO. PS Gnumeric (and GNOME/GTK+) in use are installed under /opt/gnome. Could it be relevant? PPS File type dropdown for sheets (File -> Save[ as]...) is well behaving.
Created attachment 53094 [details] [review] fixes the dialog problem Sorry, I did not look into the right dialog box. Jody, the use of gettext in gui_get_image_save_info is far from ideal. May be we should add a domain argument to this function (and rename it to go_...).
The gnumeric-pane patch looks good. Why do you call gettext directly in the 2nd ? I agree that it should be renamed.
The strings are in the gnumeric domain, using _() searches them in the goffice domain.
First patch commited. We must decide something for the second.
I found another place with untranslated strings: tooltips for entries in border toolbar button (not all: Right, Left and Bottom tooltips appears translated, other (Clear Borders, Outside Borders ...) not). I don't remember now if those messages are in goffice or gnumeric PO, sorry
Created attachment 53168 [details] [review] fixes both the dialog and border button problems Jody, we probably need a domain argument in go_action_combo_pixmaps_new too. This fixes things at the moment and are better that no fix IMHO. So my idea is to commit this patch before release with some #warning in the two files.