GNOME Bugzilla – Bug 317744
"Login photo" dialog is awful
Last modified: 2005-11-28 20:36:17 UTC
This bug has been opened here: http://bugzilla.ubuntu.com/show_bug.cgi?id=16819 "The layout of the "Login photo" dialog is dreadful, surely something better can be produced ? e.g. the browse button is tiny, there is a huge amount of empty space in the dialog, and the thumbnails are huge, they could easily be shrunk to something smaller. ... > Thanks for your bug. I agree it's not optimal, maybe you have a mockup that I could forward with the bug to upstream? ... http://bugzilla.ubuntu.com/attachment.cgi?id=4271 mockup Hmm, the layout is tricky, I'm not 100% happy with the mockup, it still has a huge amount of empty space, but I can't workout how to fill it. Basically, this moves the folder selector into the main window, so that you just select the folder, and the window shows all the images in that folder."
Maybe gdmphotosetup should be deprecated by the gnome-about-me application? Do we need two applications for defining a user image?
I think deprecating the gdmphotosetup program is a bad idea, since gnome-about-me is only supported for GNOME users. KDE users and users of other platforms should also have a photosetup program. Perhaps certain distributions that wish to make GNOME their only desktop can choose to not ship gdmphotosetup, but deprecating it isn't possible unless there is an "about-me" application that works in a way that isn't GNOME desktop specific.
See bug #319003 which is more specifically about gdmphotostup deprecation issues.
Created attachment 55134 [details] Screenshot of proposed UI I have attached a screenshot of my current proposal for gdmphotosetup. This keeps the dialog as simple as possible. Clicking on the button displays a filechooser dialog that includes a preview widget and the default face folder is listed in the shortcuts.
This looks good and clean to me. I like it. Hopefully we can also get an opinion from Sebastien.
It looks nice to me!
Feel free to commit your changes, Dennis, and close this bug. Or attach a patch and I'll do it, either way.
Change committed. 2005-11-23 Dennis Cranston <dennis_cranston@yahoo.com> * gui/gdmphotosetup.c, gui/gdmphotosetup.glade: Fix bug #317744, "Log photo dialog is awful", by simplifying the dialog.
Well, I strongly disagree that using a file selector is a better interface than using an icon chooser. Every other operating system on the planet uses an icon chooser widget.
Please compare the following to what we had before this change. OS X: http://www.golivein24.com/tips/dynamic_content/05_jaguar_fix/09_mysql_user.jpg Win XP: http://www.helpware.net/aphelp/images/useraccount.gif I think this new interface is not an improvement. The primary issue in the original bug was the placement of the browse button. That specific issue could have been addressed instead of scrapping the icon selection. Oh well...