After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 317457 - gtkmain.c: GTK_LOCALEDIR should be locale character encoding
gtkmain.c: GTK_LOCALEDIR should be locale character encoding
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Win32
2.8.x
Other All
: Normal minor
: ---
Assigned To: gtk-win32 maintainers
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2005-09-28 18:17 UTC by Kazuki Iwamoto
Modified: 2005-09-28 23:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
_gtk_get_localedir (581 bytes, patch)
2005-09-28 18:19 UTC, Kazuki Iwamoto 		none Details | Review

Description Kazuki Iwamoto 2005-09-28 18:17:27 UTC 
Please describe the problem:
GTK_LOCALEDIR is UTF-8.
But, the second argument of bindtextdomain is locale character encoding.

Steps to reproduce:
1. put files on the folder which has non-ascii character.
2. run any program.


Actual results:
Strings are not translated.

Expected results:
Convert the reesult from g_win32_get_package_installation_subdirectory by using
g_win32_locale_filename_from_utf8 at _gtk_get_localedir.

Does this happen every time?
every time

Other information:
Comment 1 Kazuki Iwamoto 2005-09-28 18:19:03 UTC 
Created attachment 52783 [details] [review]
_gtk_get_localedir
Comment 2 Kazuki Iwamoto 2005-09-28 18:29:04 UTC 
"fix get_atk_locale_dir" is my mistake.
"fix _gtk_get_localedir" is correct.
Please see following bug.
http://bugzilla.gnome.org/show_bug.cgi?id=317458
Comment 3 Tor Lillqvist 2005-09-28 23:46:30 UTC 
Argh, thanks. This issue has been taken care of in the GNOME platform libs, but
then forgotten in GTK+ itself, sigh. Fixed in gtk-2-8 and HEAD:

2005-09-29  Tor Lillqvist  <tml@novell.com>

	* gtk/gtkmain.c (_gtk_get_localedir): The locale directory is
	passed to bindtextdomain() which isn't UTF-8-aware, so convert to
	system codepage using g_win32_locale_filename_from_utf8().
	(#317457, Kazuki Iwamoto)