After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 317158 - vte does not respect size settings if child not forked
vte does not respect size settings if child not forked
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: VTE Maintainers
VTE Maintainers
: 332927 (view as bug list)
Depends on:
Blocks: 339819
 
 
Reported: 2005-09-25 13:22 UTC by JP Rosevear
Modified: 2010-03-25 13:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
size requests based on programatically set size (1.96 KB, patch)
2005-09-25 13:24 UTC, JP Rosevear 		none Details | Review
updated to HEAD: always use the current column x row (923 bytes, patch)
2007-01-20 22:19 UTC, Chris Wilson 		none Details | Review
And update the debug printout. (1.34 KB, patch)
2007-01-20 22:20 UTC, Chris Wilson 		none Details | Review

Description JP Rosevear 2005-09-25 13:22:35 UTC 
Please describe the problem:
When doing size request, if there no child forked by the terminal (pty_master =
= -1) then the request is based on the default column/row counts rather the the
programmatic size set.  Attached patch changes this, but I'm not sure there is a
rationale for things working this way.



Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 JP Rosevear 2005-09-25 13:24:11 UTC 
Created attachment 52629 [details] [review]
size requests based on programatically set size
Comment 2 Chris Wilson 2007-01-20 22:19:02 UTC 
Created attachment 80777 [details] [review]
updated to HEAD: always use the current column x row

The current behaviour does seem very strange.
Comment 3 Chris Wilson 2007-01-20 22:20:24 UTC 
Created attachment 80779 [details] [review]
And update the debug printout.
Comment 4 Mariano Suárez-Alvarez 2007-01-20 23:34:34 UTC 
FWIW, Nalin did essentially the opposite change a while back: cf. <http://bugzilla.gnome.org/show_bug.cgi?id=317158> and scroll down towards the middle of that (huge!) patch.
Comment 5 Mariano Suárez-Alvarez 2007-01-20 23:58:12 UTC 
Oops. The URL above should have been: <http://svn.gnome.org/viewcvs/vte/trunk/src/vte.c?rev=273&r1=271&r2=273>.
Comment 6 Chris Wilson 2007-01-22 17:10:17 UTC 
*** Bug 332927 has been marked as a duplicate of this bug. ***
Comment 7 Behdad Esfahbod 2007-11-28 13:31:40 UTC 
Final patch anyone?
Comment 8 Behdad Esfahbod 2007-11-28 14:06:57 UTC 
err, didn't mean that.
Comment 9 Christian Persch 2009-12-03 17:07:34 UTC 
The commit message for the commit in comment 5 doesn't give any clue as to this particular change...

FWIW, I've been running with the patch here for a long time and haven't observed any problems. I think we should just commit it.
Comment 10 Behdad Esfahbod 2009-12-03 17:17:43 UTC 
Go for it.
Comment 11 Christian Persch 2010-03-25 13:17:42 UTC 
Fixed on master.