GNOME Bugzilla – Bug 317097
Option to use the same proxy for all protocols
Last modified: 2007-01-06 17:56:33 UTC
It is possible that the same proxy server is used for HTTP, HTTPS, FTP and SOCKS protocols. In this case the user has to enter the proxy settings four times. It would be useful to have a check box which disables three of the protocol fields, and then copies the settings entered into the fourth one into the other three fields. See the Mozilla Firefox proxy settings for an example.
Thanks for your bug. That's an easy task for contributors, updating according to that
I'm working on this bug. I'm wondering how I should implement this... Should I... - Add a gconf key reflecting the status of the "use this proxy server for all protocols" option, allowing the SHTTP, FTP and Socks protocol configuration values to remain intact should this option be disabled later? Or... - Modify the gconf keys for SHTTP, FTP and Socks protocol configurations instantly when this option is enabled? As far as I can see, Mozilla Firefox remembers the old values, so disabling the option restores the old configuration values.
First, thank you for working on that. Your point about mozilla firefox make sense, you should probably have a common key so the other keys don't change
(In reply to comment #3) > First, thank you for working on that. Your point about mozilla firefox make > sense, you should probably have a common key so the other keys don't change > Hmm, won't having a common key break compatibility with applications using the /system/proxy gconf entries? If so, an optional approach could be to save the original SHTTP, FTP and Socks values in some other gconf keys, retrieving them when the global proxy option is disabled... Ideas?
Created attachment 64411 [details] [review] Adds the 'Use same proxy' option Hello, I think I have made a patch for this. It adds OLD_*_HOST_KEY and OLD_*_PORT_KEY keys to store the values before the clicking of 'use same proxy'. Adds a cb_use_same_proxy_checkbutton_clicked function to turn the Entry widgets insensitive and store/restore values. I tried to stick to the GConfPropertyEditor stuff. The glade file has obvious modifications, but also some weird changes that my glade-2 introduced (I'm not sure if this is a bad thing...), please check the patch. I hope this works!!!
ping
ping pong.
This patch doesn't apply cleanly to CVS HEAD, and, apart from that, there is one thing: In cb_use_same_proxy_checkbutton_clicked, you need to g_object_unref the GConfClient So please, update the patch and I'll approve it
I just CO HEAD and it had a weird glade file, I'll try again later.
Created attachment 75753 [details] [review] Updated patch This patch is against 2.16.1, sadly I'm pretty newbie with CVS :(. Please let me know if this doesn't apply flawlessly to CVS, in that case I will learn some CVS magic to update it :).
Created attachment 77671 [details] [review] Patch against latest CVS Works fine in latest CVS version of g-c-c. Is identation ok?
\o/
Needs a mnemonic on the checkbox label, but other than that looks fine. It's a shame we have to add a bunch of _old keys, but I can't see any way of storing the previous data right now.
Patch committed with the mnemonic in place