After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 316203 - MinGW: udp and rtsp plugin should be disabled on windows
MinGW: udp and rtsp plugin should be disabled on windows
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Windows
: Normal normal
: 0.10.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 316073
 
 
Reported: 2005-09-13 13:48 UTC by Michal Benes
Modified: 2006-05-03 02:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch disabling compilation of RTSP and UDP on Windows (1.16 KB, patch)
2005-10-14 16:33 UTC, Michal Benes
rejected Details | Review

Description Michal Benes 2005-09-13 13:48:52 UTC
Plugins debug, rtsp and udp from gst-plugins-good do not compile on Windows.

The reason is that debug depends on sys/mman and rtsp, udp depend on networking,
which needs to be ported to winsock.
Comment 1 Tim-Philipp Müller 2005-10-07 11:34:56 UTC
I've fixed this for debug:

  2005-10-07  Tim-Philipp Muller  <tim at centricular dot net>

        * configure.ac:
          Add check for mmap

        * gst/debug/Makefile.am:
          Only compile efence plugin on systems that have mmap.

but the network stuff in rtsp/udp still needs porting to Winsock (or disabling,
dunno).

Comment 2 Michal Benes 2005-10-14 16:33:43 UTC
Created attachment 53476 [details] [review]
Patch disabling compilation of RTSP and UDP on Windows

This patch disables these two plugins on Windows in the same way as c++
dependent plugins are disabled in gst-pplugins-base. It would be better to port
these plugins to winsock, but I am not motivated enough to do so in the moment.
Comment 3 Tim-Philipp Müller 2006-03-17 10:58:22 UTC
The patch doesn't look entirely correct to me, as gst-plugins-good/gst/Makefile.am contains

 SUBDIRS = $(GST_PLUGINS_SELECTED)
 DIST_SUBDIRS = $(GST_PLUGINS_ALL)

meaning 'make dist' wouldn't dist the udp and rtsp subdirs when run on win32. Should be easy to fix, just need to check what the prefered way is.

Comment 4 Michal Benes 2006-03-17 13:16:57 UTC
I know this patch is not 100% correct. But c++ dependent plugins were disabled in exactly the same way in gst-plugins-base in the time of this patch the creation. I have not seen any mechanism in other configure scripts to disable plugins from gst (they are probably supposed to always compile).
Comment 5 Tim-Philipp Müller 2006-03-17 15:33:41 UTC
Fixed this slightly differently (still ugly, but should work):

  2006-03-17  Tim-Philipp Müller  <tim at centricular dot net>

       * configure.ac:
         Don't compile udp and rtsp plugins on win32 (mingw) or other
         systems that don't have <sys/socket.h> for some reason (#316203).