After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 315571 - last release borke --disable-encoders
last release borke --disable-encoders
Status: RESOLVED DUPLICATE of bug 312764
Product: GStreamer
Classification: Platform
Component: gst-libav
0.8.10
Other Linux
: Normal normal
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-09-08 19:41 UTC by Loïc Minier
Modified: 2005-10-03 11:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
disable-encoder fix (1.15 KB, patch)
2005-09-08 19:45 UTC, Loïc Minier 		none Details | Review

Description Loïc Minier 2005-09-08 19:41:28 UTC 
Hi,

(I thought having filed a bug on this issue, but I can't put my hand on it.)

in gst-ffmpeg 0.8.6, one can't configure ffmpeg with --disable-encoder anymore.

This is because configure checks whether all AC_DEFINEd values are set, and the
AC_FF_ALLOW_DISABLE calls are within the AC_FF_ALLOW_DISABLE(CONFIG_ENCODERS)
conditional block.

Ronald already fixed this, but lost the patch, and suggested I file a bug so
that he doesn't forget about the issue.

Anyway, I tried solving the issue and I came with a patch that I'll attach so we
can discuss it.
Comment 1 Loïc Minier 2005-09-08 19:45:31 UTC 
Created attachment 51985 [details] [review]
disable-encoder fix

This patch will change the default value of the encoders if --disable-encoders
is used and this permits:
--disable-encoders => disable all
--disable-encoders --enable-encoder-flv OR --enable-encoder-flv
--disable-encoders => disable all except FLV

However, it exposes things twice in --help:
  --disable-encoder-h261	  Disable h.261 encoder
  --enable-encoder-h261 	  Enable h.261 encoder

What do you think of this approach?  I find the configure output ugly but
bearable, and the use cases are nice.
Comment 2 Ronald Bultje 2005-09-08 20:09:23 UTC 
CVS already does this... I forgot to apply the patch before releasing 0.8.6.
Comment 3 Loïc Minier 2005-09-08 20:16:27 UTC 
Ups, merging...

*** This bug has been marked as a duplicate of 312764 ***