After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 315189 - sidebar causes image not to be at 100% when it reasonably can be
sidebar causes image not to be at 100% when it reasonably can be
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: image viewer
2.11.x
Other Linux
: Normal normal
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks: 313674
 
 
Reported: 2005-09-03 18:13 UTC by Allison Karlitskaya (desrt)
Modified: 2005-09-05 14:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
pane pain (1.48 KB, patch)
2005-09-03 18:58 UTC, Allison Karlitskaya (desrt)
committed Details | Review

Description Allison Karlitskaya (desrt) 2005-09-03 18:13:24 UTC
Distribution/Version: breezy -- the badger of power

if you open an image in eog with the sidebar enabled then I think something like
the following must happen:

1) size of image is determined
2) window size is set accordingly
3) sidebar is added, thus reducing available space for the image
4) image is rescaled to fit into the reduced space

as such, opening images almost never results in them being at 100% zoom level
when they reasonably could be, but rather at 80- or 90-something.

when opening images with the sidebar disabled the problem does not occur.
Comment 1 Allison Karlitskaya (desrt) 2005-09-03 18:14:09 UTC
Forgot to mention: might want to try to nuke bug #313674 at the same time as
this one.
Comment 2 Allison Karlitskaya (desrt) 2005-09-03 18:53:53 UTC
This regression was introduced here:

http://cvs.gnome.org/viewcvs/eog/shell/eog-window.c?r1=1.125&r2=1.126

Search for "Line 2438".

Reverting that one piece of the patch would solve this bug and bug 313674.
Comment 3 Allison Karlitskaya (desrt) 2005-09-03 18:58:19 UTC
Created attachment 51768 [details] [review]
pane pain
Comment 4 Brent Smith (smitten) 2005-09-03 21:08:36 UTC
I can confirm that the patch fixes the issue.
Comment 5 Tim Gerla 2005-09-05 12:51:27 UTC
Patch applied. Thanks.