After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 314669 - Please specialize AC_PATH_XTRA
Please specialize AC_PATH_XTRA
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: VTE Maintainers
VTE Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-08-27 20:26 UTC by Loïc Minier
Modified: 2007-01-22 14:26 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Loïc Minier 2005-08-27 20:26:58 UTC
Hi,

vte's configure calls AC_PATH_XTRA without arguments; that will autodetect X
based on _AC_PATH_X([Xt],[X11/Intrinsic.h],[XtMalloc (0)]), but vte doesn't use
any of these.

Since the recent modularization of Xorg, this is distributed in a separate
development package (in Debian at least).

It would be nice if you could drop the useless build dependency on the package
holding X11/Intrinsic.h + XtMalloc, for example you could specialize the
AC_PATH_XTRA call.

Previously, a Debian maintainer used "AC_PATH_XTRA( [X11], [X11/Xlib.h], [XSync
()])", but I think this might not be optimal (XSync isn't used if gtk >= 2.2.0).

You might want to use one of the symbols vte relies on:
00000000      DF *UND*  000000b0              XftDrawRect
00000000      DF *UND*  0000011c              XftDrawCharFontSpec
00000000      DF *UND*  000000dd              XFreeGC
00000000      DF *UND*  00000104              XCopyArea
00000000      DF *UND*  000000a0              XftDrawDestroy
00000000      DF *UND*  00000133              XftColorAllocValue
00000000      DF *UND*  000000d6              XftTextExtents32
00000000      DF *UND*  0000006e              XftFontOpenPattern
00000000      DF *UND*  000000a8              XftDrawCreate
00000000      DF *UND*  0000004c              XftColorFree
00000000      DF *UND*  00000038              XftCharExists
00000000      DF *UND*  0000006e              XftFontClose
00000000      DF *UND*  000001b9              XCreateGC

For example, XCreateGC seems like a valid candidate, but requires some arguments.

I'll let you decide of the implementation, XSync is probably ok and is working here.

Bye,
Comment 1 Kjartan Maraas 2005-08-29 08:57:22 UTC
Is this at all related to bug 162003?
Comment 2 Loïc Minier 2005-08-29 12:01:23 UTC
No, bug 162003 describes what happens immediately after AC_PATH_XTRA is used.

This bug is about AC_PATH_XTRA detecting a partial X11 development files
installation, ie. correctly detecting X build options for vte when only the
necessary files are present, and not the files checked for in the default
AC_PATH_XTRA check.
Comment 3 Chris Wilson 2007-01-22 14:26:10 UTC
r1492: 2007-01-22  Chris Wilson <chris@chris-wilson.co.uk>

	Hack'n'slash my way through doing a bit of weeding.

	Fixed:
	- Bug 345514 – -no-undefined doesn't work with latest libtool
	- Bug 162003 – vte configure.in X checking can fail
	             – though this may cause other regressions!
	- Bug 314669 – Please specialize AC_PATH_XTRA

	* configure.in:
		Export LIBTOOL_EXPORT_OPTIONS for -no-undefined on windos.
		Add to rather than override X_CFLAGS, X_LIBS
		AC_PATH_XTRA - Find X11 using XFlush() rather than XtMalloc().
		Print configuration details.
	* src/Makefile.am:
		Conditional compilation of backends.