After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 314658 - Theme chooser main window too wide for 800x600
Theme chooser main window too wide for 800x600
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: [obsolete] theme-manager
2.11.x
Other All
: Normal minor
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
: 331741 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-08-27 14:48 UTC by Steve Frécinaux
Modified: 2006-04-12 19:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.11/2.12


Attachments
The window which is too wide (47.78 KB, image/png)
2005-08-30 23:55 UTC, Steve Frécinaux
  Details
Allow the theme manager to reduce to 500x400 (1.11 KB, patch)
2006-01-03 23:02 UTC, Thomas Wood
needs-work Details | Review
"ellipsize" prop. for TreeView (794 bytes, patch)
2006-02-18 23:36 UTC, Sergey Al. Safonov
accepted-commit_after_freeze Details | Review

Description Steve Frécinaux 2005-08-27 14:48:14 UTC
The main window of the theme chooser is hard to use in 800x600 because it's
about 100px too wide, and it isn't possible to resize it smaller.

It wouldn't be difficult to make this window stand on a 800x600 screen, because
most of the width is used for the theme descriptions (thumbnail, title and
desc). No description is long enough to take the whole width of that list.
Anyway, if there where, why not to make them multiline so we could have a
smaller theme chooser window, which could stay on a 800x600 screen ?

On the other hand, the theme details window is just fine.

Other information:
Comment 1 Steve Frécinaux 2005-08-30 23:55:55 UTC
Created attachment 51592 [details]
The window which is too wide

The window which is too wide. You can see that descriptions stays on one line,
and that there are lots of useless empty space.
Comment 2 Thomas Wood 2005-12-30 15:03:03 UTC
Obviously a problem for users with 800x600 screen resolution. I can't see any reason why it shouldn't be able to be resized smaller.
Comment 3 Thomas Wood 2006-01-03 23:02:05 UTC
Created attachment 56739 [details] [review]
Allow the theme manager to reduce to 500x400

Could you try this patch and let me know if it solves your problem.
Comment 4 Steve Frécinaux 2006-01-03 23:23:04 UTC
(In reply to comment #3)

This looks ok, the dialog can easily stand on a 800x600 screen from now on, with this patch.
Comment 5 Sebastien Bacher 2006-01-04 23:44:04 UTC
Fixing the size is not really nice. It has a weird ratio and cut quite a bunch of title by default with that change. The patch should rather wrap or ellipsize the title when required

Comment 6 Sergey Al. Safonov 2006-02-18 23:34:27 UTC
I have prepared patch. It just sets the "ellipsize" property for TreeView because "ellipsize" have a nicer look than "wrap".I tried to use both "ellipsize" and "wrap" properties but seems than only one of that properties works.
Comment 7 Sergey Al. Safonov 2006-02-18 23:36:36 UTC
Created attachment 59673 [details] [review]
"ellipsize" prop. for TreeView
Comment 8 Steve Frécinaux 2006-03-06 08:23:53 UTC
"wrap" requires you to set the character number where the text is wrapped (cf doc) so it is normal it does not work.

Besides, I just tested the previous patch (comment #7) and it works great. (hope it is not too late for freeze)
Comment 9 Thomas Wood 2006-03-06 11:32:22 UTC
Freeze is tonight.

Sebastien: Is there any reason not to commit this before tonight?
Comment 10 Sebastien Bacher 2006-03-19 22:06:48 UTC
Patch looks good to me but is an UI change probably. Feel free to commit after the freeze
Comment 11 Thomas Wood 2006-04-09 16:23:42 UTC
2006-04-09  Thomas Wood  <thos@gnome.org>

        * gnome-theme-manager.c: (setup_meta_tree_view): Patch from Sergey Al.
        Safonov <spoof@spoofa.info> to fix bug 314658 - Theme chooser main
        window too wide for 800x600
Comment 12 Thomas Wood 2006-04-12 19:47:49 UTC
*** Bug 331741 has been marked as a duplicate of this bug. ***