GNOME Bugzilla – Bug 313893
Source List resized automagically when create / delete playlist
Last modified: 2005-09-24 09:24:27 UTC
With a CVS version of RB (18-Aug-05): 1/ Be sure the Source List is displayed 2/ Create a new playlist with shortcut Result: the Source List is resized The same behaviour appears when deleting playlist I think the problem appears after patch from bug 161935 was commited to CVS.
I think I've found the cause of the problem: a) the patch in bug 161935 forces RB to come out of small mode when a playlist is created. b) when RB gets told to come out of small mode it maximises the window, even is it is not in small mode. I think the answer if to either a) don't maximise when coming out of small mode (return to the previous size) or b) ignore the request to come out of small mode if we are were not in it previously.
I've found the actual problem: the gconf key CONF_STATE_WINDOW_MAXIMIZED is used, but isn't actually set anywhere. Fixing this should just be a matter of setting this when the window is maximised/unmaximised.
Created attachment 52393 [details] [review] patch The patch makes Rhythmbox actually stop the maximisation state, window width and height in the gconf keys. It should also fix bugs 137068 and 310252.
Created attachment 52582 [details] [review] better patch This patch actually fixes the first of the two other bug I mentioned, but still doesn't fix the latter though. We should also probably monitor the gconf keys for changes, but that will probably lead to issues (e.g. when the state is changed quickly) because of the asynchonous nature of gconf.
Patch committed.