After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 313649 - [patch] totem_pl_parser_class_init fills in signal table wrong
[patch] totem_pl_parser_class_init fills in signal table wrong
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: general
1.1.x
Other Linux
: Normal major
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2005-08-16 18:00 UTC by James "Doc" Livingston
Modified: 2005-08-16 19:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description James "Doc" Livingston 2005-08-16 18:00:50 UTC 
line 122 (in cvs) of totem_pl_parser_class_init [totem-pl-parser.c] has
PLAYLIST_START rather than PLAYLIST_END, which causes the playlist-end signal
not to be registered properly. The result of which is "GLib-GObject-CRITICAL **:
g_signal_emit_valist: assertion `signal_id > 0' failed" whenever the signal
should have been emitted.


diff -u -r1.76 totem-pl-parser.c
--- src/plparse/totem-pl-parser.c       22 Jul 2005 12:48:32 -0000      1.76
+++ src/plparse/totem-pl-parser.c       16 Aug 2005 18:00:16 -0000
@@ -109,7 +109,7 @@
                              NULL, NULL,
                              g_cclosure_marshal_VOID__STRING,
                              G_TYPE_NONE, 1, G_TYPE_STRING);
-       totem_pl_parser_table_signals[PLAYLIST_START] =
+       totem_pl_parser_table_signals[PLAYLIST_END] =
                g_signal_new ("playlist-end",
                              G_TYPE_FROM_CLASS (klass),
                              G_SIGNAL_RUN_LAST,
Comment 1 Bastien Nocera 2005-08-16 19:03:02 UTC 
2005-08-16  Bastien Nocera  <hadess@hadess.net>

        * src/plparse/totem-pl-parser.c: (totem_pl_parser_class_init):
        Fix generation of the "playlist-end" signal, patch from
        James Livingston <jrl@ids.org.au> (Closes: #313649)