After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 313350 - Return type of gtk_accelerator_get_default_mod_mask should be GdkModifierType
Return type of gtk_accelerator_get_default_mod_mask should be GdkModifierType
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
2.91.x
Other All
: Normal normal
: 3.0 API Freeze
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2005-08-12 18:17 UTC by Johan (not receiving bugmail) Dahlin
Modified: 2010-10-15 18:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch: Make gtk_accelerator_get_default_mod_mask() return a GdkModifierType (2.04 KB, patch)
2010-10-11 14:56 UTC, Alberto Garcia 		accepted-commit_now Details | Review

Description Johan (not receiving bugmail) Dahlin 2005-08-12 18:17:11 UTC 
The return type of gtk_accelerator_get_default_mod_mask is currently set to
guint, but for consistency it should be set to GdkModifierType, just as the setter.

It may be an ABI/API break for C++ as Owen pointed out on IRC.
Comment 1 Alberto Garcia 2010-10-11 14:56:39 UTC 
Created attachment 172100 [details] [review]
Patch: Make gtk_accelerator_get_default_mod_mask() return a GdkModifierType
Comment 2 Matthias Clasen 2010-10-15 03:34:39 UTC 
Review of attachment 172100 [details] [review]:

ok