After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 313096 - Plugin collision prevention too aggressive in the junk hook
Plugin collision prevention too aggressive in the junk hook
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.4.x (obsolete)
Other Linux
: Normal major
: Future
Assigned To: vivek jain
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2005-08-10 11:17 UTC by Mikhail Zabaluev
Modified: 2013-09-13 00:48 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Mikhail Zabaluev 2005-08-10 11:17:14 UTC
In the emjh_construct function in em-junk-hook.c, the 'loaded' static variable
is used to prevent multiple plugins from being attached to the same hook. The
problem is, when the first available plugin candidate is disabled in the plugin
manager, its processing still sets 'loaded' to TRUE and prevents another
available plugin from being attached.
It takes removing the conflicting .eplug manifesto from the plugin directory to
enable the second plugin.

On a more general note, shouldn't resolution of hook conflicts be handled in
some generic way in the EPlugin system?
Comment 1 Not Zed 2005-08-19 04:08:07 UTC
does it work if you enable/disable the right plugin, then restart?  the plugin
manager does say that changes may not take effect till restart.

and no, the eplugin system cannot resolve hook conflicts.  it is up to the hooks
themselves to do it since they know what they're dealing with.


Comment 2 Mikhail Zabaluev 2005-08-19 06:52:33 UTC
No, the problem is persistent. sa-junk-plugin is disabled, and my bogofilter
junk plugin is enabled, but as the first one comes first in the eplugin
initialization list, it prevents the enabled one from being considered for the hook.
Comment 3 Not Zed 2005-08-25 05:30:26 UTC
something to look into vivek?
Comment 4 André Klapper 2005-11-30 23:30:56 UTC
vivek: ping?
mikhail got a bogofilter plugin and this prevents a proper implentation of any
other antispam plugin.

raising priority.
Comment 5 parthasarathi susarla 2006-01-31 09:06:46 UTC
This is fixed on HEAD in the 2.4 cycle itself. find it here http://cvs.gnome.org/viewcvs/evolution/mail/em-junk-hook.c?r1=1.2&r2=1.3

closing bug.