After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 312941 - Translations do not work at all
Translations do not work at all
Status: RESOLVED FIXED
Product: gimp-tiny-fu
Classification: Other
Component: Internationalization
1.0
Other Windows
: High normal
: 1.0
Assigned To: GIMP Tiny-fu plug-in maintainer alias
GIMP Tiny-fu plug-in maintainer alias
Depends on:
Blocks:
 
 
Reported: 2005-08-08 21:11 UTC by Michael Schumacher
Modified: 2006-04-25 22:23 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed changes (3.56 KB, patch)
2005-08-08 21:13 UTC, Sven Neumann
rejected Details | Review

Description Michael Schumacher 2005-08-08 21:11:01 UTC
Please describe the problem:
In Tiny-Fu 1.0, translations do not work. Regardless of the language
environment, the menu entries and GUI labels always display in English. 

Steps to reproduce:
1. Start GIMP with LANG set to anything not being 'en'
2. Navigate to Tiny-Fu related menu entries and
3. Launch some of them



Actual results:
There is a problem with the names for the .mo files - using a file monitor, one
can see that gimp-tiny-fu-tiny-fu is searched, but not found - but renaming the
file doesn't fix this.

Expected results:
Localized menus

Does this happen every time?
Yes

Other information:
Comment 1 Sven Neumann 2005-08-08 21:12:46 UTC
Handling of i18n should be redone in tiny-fu, equivalent to the changes that
have recently been applied to the plug-in template.
Comment 2 Sven Neumann 2005-08-08 21:13:37 UTC
Created attachment 50417 [details] [review]
proposed changes
Comment 3 Sven Neumann 2005-08-08 22:43:24 UTC
That patch has issues since it will break relocalibility which is important for
the package to work on Win32.
Comment 4 Kevin Cozens 2005-08-09 00:54:39 UTC
2005-08-08  Kevin Cozens  <kcozens@cvs.gnome.org>

        * tiny-fu/tiny-fu-intl.h: Don't append -tiny-fu to GETTEXT_PACKAGE.
        Spotted by Sven Neumann. Fix for bug #312941.

The above change was made to both branches of Tiny-Fu. Now awaiting for
confirmation that translations are working once again in Windows.
Comment 5 Kevin Cozens 2005-08-09 19:38:36 UTC
Translations are working once again on Windows. Closing this report.
Comment 6 Kevin Cozens 2005-09-05 20:47:41 UTC
Reopening this report. Michael Shumacher has reported that translations are
still not working in Tiny-Fu when used with GIMP for Windows.
Comment 7 Michael Schumacher 2005-09-10 21:03:29 UTC
The problem is the fixed LOCALEDIR that was introduced by the patch. On Windows,
the location of the translations can only be determined when GIMP is run - there
is no fixed location where GIMP is installed (we have drive letters, for
example), the file system is localized (different names for directories,
depending on the language), and the directory structure simply isn't a fxied
tree like on unix systems.

Doesn't mean that the locale files have to be in GIMP's installation directory -
there is a place for shared files - but the definite location can only be
determined at runtime.
Comment 8 Sven Neumann 2005-09-12 16:28:48 UTC
I think I pointed out that the changes that I proposed in comment #2 are wrong
and should not be applied. As far as I understood comment #4, this hasn't
happened and the only change that has been done is not to append -tiny-fu to
GETTEXT_PACKAGE in tiny-fu-intl.h. I don't see how that introduces a fixed
LOCALEDIR.

BTW, the changes that have been made to the plug-in template should better be
reverted as well...
Comment 9 Michael Schumacher 2006-04-25 22:23:59 UTC
Translations are working in 1.0.1