GNOME Bugzilla – Bug 312114
[PATCH]gnomevfssrc unneccessarily registers callbacks with gnome-vfs in some cases
Last modified: 2006-01-27 09:19:36 UTC
Please describe the problem: For iradio metadata information gnomevfssrc registers callbacks with gnome-vfs to send & recieve additional headers. If gnomevfssrc is NOT in iradio mode, it still registers this callbacks, which interfere with other applications that may need to send & recieve additional headers. I am adding iTunes Music Sharing support to Rhythmbox. The communcation is done via HTTP 1.1, and so for getting music files I use an http:// uri passed to a gstreamer playbin element. However, I need to send additional headers (a hash of the file path for authentication purposes) so that iTunes will actually send the file. But, since gnomevfssrc /always/ registers the send/recieve callbacks (and strangely enough it seems gnome-vfs can only have 1 set registered), my callbacks are never run. Since this is /definitly/ not iradio mode, the callbacks do not need to be registered in gnomevfssrc. I have a patch against gst-plugins 0.8.10, and can remake it against CVS (the 0.8 branch?, so that this can get into Rhythmbox before RB works with 0.9?) if needed. Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
Created attachment 50004 [details] [review] patch to gstgnomevfssrc.c
thanks for sending in. confirming so maintainers can have a look at it
Patch looks reasonable to me (I wrote most of the iradio-mode support).
committed to 0.8 cvs, thanks!
Change patch status to committed.