After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 312080 - [0.9] [API] GST_BUFFER_FOO_IS_VALID(buf) is bad API
[0.9] [API] GST_BUFFER_FOO_IS_VALID(buf) is bad API
Status: RESOLVED INVALID
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: NONE
Assigned To: Wim Taymans
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-07-30 19:31 UTC by Tim-Philipp Müller
Modified: 2005-09-02 15:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Tim-Philipp Müller 2005-07-30 19:31:44 UTC 
Currently we have a couple of macros like this:

  GST_BUFFER_OFFSET_IS_VALID (buffer)


That is bad API IMHO and should rather be:

  GST_BUFFER_OFFSET_IS_VALID (offset)
    and
  GST_BUFFER_HAS_VALID_OFFSET (buffer)


(I'd be willing to fix gstreamer, gst-plugins-base and gst-plugins of course if
people agree that the suggested API is better).

 Cheers
  -Tim
Comment 1 Tim-Philipp Müller 2005-07-30 19:34:59 UTC 
Note also that it is

  GST_CLOCK_TIME_IS_VALID (clocktime)

so that's also a bit inconsistent with the current API

Cheers
 -Tim
Comment 2 Christian Kirbach 2005-07-31 16:49:05 UTC 
any word from the maintainers on this?
Comment 3 Tim-Philipp Müller 2005-09-02 15:17:13 UTC 
I guess it's best to just leave it as is, unless we also want to change all the
accessor macros like GST_BUFFER_OFFSET etc., which seems a little bit over the
top . => closing.

Cheers
 -Tim