After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 311920 - Should be able to rearrange the device list view's column headers
Should be able to rearrange the device list view's column headers
Status: RESOLVED FIXED
Product: system-monitor
Classification: Core
Component: general
git master
Other Linux
: Normal enhancement
: ---
Assigned To: System-monitor maintainers
System-monitor maintainers
Depends on:
Blocks:
 
 
Reported: 2005-07-29 06:20 UTC by Dennis Cranston
Modified: 2011-11-11 10:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (7.64 KB, patch)
2005-12-29 07:19 UTC, Dennis Cranston 		none Details | Review

Description Dennis Cranston 2005-07-29 06:20:53 UTC 
On the processes tab, the list view's column headers can be rearranged and the
order is remembered when gnome-system-monitor is relaunched.

On the device tab, the list view's column headers cannot be rearranged.  It
would be great if the columns could be rearranged here too.
Comment 1 Dennis Cranston 2005-12-29 07:19:26 UTC 
Created attachment 56499 [details] [review]
Proposed patch

2005-12-28  Dennis Cranston  <dennis_cranston@yahoo.com>

	* src/disks.c: (cb_disk_columns_changed), (create_disk_view):
	* src/gnome-system-monitor.schemas.in:
	* src/procman.c: (procman_get_tree_state),
	(procman_save_tree_state):  Allow user to sort the device 
	list.  Fixes bug #311920
Comment 2 Benoît Dejean 2005-12-29 08:18:39 UTC 
Looks fine (except some 'space before parent' stylistic issues).
Comment 3 Dennis Cranston 2005-12-29 08:26:10 UTC 
I applied the patch to CVS head with the 'space before parent' issues fixed.
Comment 4 Benoît Dejean 2005-12-29 08:35:31 UTC 
I'd appreciate you to ask before commit. Or wait for 'commit-now' on patches. And btw, all the 'space before parent' are not gone. There are still some 'function (arg)' in the patch you applied.
Comment 5 Dennis Cranston 2005-12-29 16:50:10 UTC 
Sorry about that, I misunderstood your "Looks fine" comment.  Do you want me to reverse the commit?
Comment 6 Benoît Dejean 2005-12-30 08:40:39 UTC 
No, but be careful, i appreciate your work, but when i want you to commit a patch, i change its status .