After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 311074 - Patch fixing several memory leaks in memo file conduit
Patch fixing several memory leaks in memo file conduit
Status: RESOLVED FIXED
Product: gnome-pilot
Classification: Other
Component: conduit: memo_file
2.0.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-pilot Maintainers
gnome-pilot Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-07-21 02:45 UTC by Mark Adams
Modified: 2005-08-10 13:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch fixing memory leaks (2.14 KB, patch)
2005-07-21 02:46 UTC, Mark Adams
committed Details | Review
Changelog entry (333 bytes, patch)
2005-07-21 02:46 UTC, Mark Adams
committed Details | Review

Description Mark Adams 2005-07-21 02:45:05 UTC
Version details: gnome-pilot-conduits-2.0.13-1
Distribution/Version: Fedora Core 4

While working on getting gnome-pilot-conduits working on FC4 (see bug #274032),
I ran into several memory leaks in the memo conduit.

1) filenames were being leaked in generate_name, as the local record may well
already have a filename set but we were unconditionally overwriting it

2) filenames were being leaked in load_records if category == 16; we were doing
a continue, but not freeing the locally allocated filename

3) keys in the hashtable were never being freed. In fact, the hash table memory
management can be made substantially cleaner just by using g_hash_table_new_full

The attached patch fixes these three bugs. In addition, a changelog entry has
been attached.
Comment 1 Mark Adams 2005-07-21 02:46:10 UTC
Created attachment 49494 [details] [review]
Patch fixing memory leaks
Comment 2 Mark Adams 2005-07-21 02:46:29 UTC
Created attachment 49495 [details] [review]
Changelog entry