GNOME Bugzilla – Bug 310747
[ximagesrc] Segfaults when using a bpp != 32
Last modified: 2005-10-21 16:29:56 UTC
ximagesrc segfaults when trying to blend the X cursor over the frame if the bpp of your X server is different than 32 (i've tested with 16). This: composite_pixel ((guchar *) & (((guint32 *) image->ximage->data)[j * s->width + i]), (guchar *) & (((guint32 *) cursor_image->pixels)[(j - cy) * cursor_image->width + (i - cx)])); is correct only if every pixel is 32 bit wide. s/guint32/guint16 to make it works with 16bpp. The function "composite_pixel" should also support different bpp and different masks. If anyone is faster than me i'll take a look ASAP.
Created attachment 49427 [details] [review] first patch First patch, needs to be tested on a X server with bpp != 16 * add support for 8/16/32 bpp * support different masks * fix a bug in finding X cursor dimension * enjoy I'll try to test better the patch whenever possible.. but i don't know if i'll have time soon :(
already fixed..