GNOME Bugzilla – Bug 310298
remove out of date thumbnails and force the regeneration
Last modified: 2007-03-04 13:10:59 UTC
The Ubuntu package has this patch: * debian/patches/15_unlink_out_of_date_thumbs.patch: - Compare mtime of filename and thumbnail without following symlinks, if either doesn't exist or the thumbnail mtime is older, remove the thumbnail and force regeneration.
Created attachment 49132 [details] [review] patch from Scott James Remnant <scott@netsplit.com> updated for the current version
wrong patch
Created attachment 49134 [details] [review] patch from Scott James Remnant <scott@netsplit.com> for this bug
This looks like something that perhaps belongs in libgnomeui or something? At least, I would think that thumbnail invalidation belongs in the thumbnail implementation. Aside from that though, the patch is wrong. It looks to me like it only tries to invalidate the thumbnail, if we generated the URI to the thumbnail filename internally, rather than always. Though, always regenerating a thumbnail seems like a rather silly performance hit. Especially since we calculate the sizes of things, and add additional information to the thumbnails. It seems to me like the algorithm for invalidating thumbnails should perhaps be more verbose as well. I would tend to expect that the thumbnail and original image file, would have different mtime values, as they are different files.
Seems to have no dups. Confirming.
I just approved a patch from Ray Strode, which Rodrigo just committed, that changes the way some of the thumbnail stuff works. It seems like it would fix any issues presented in this bug. Can you test SVN (or 2.17.5 when it gets released shortly), to verify that?
there has been no bug about the new version, marking fixed. I'll reopen if required