After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 309375 - cdparanoia can't extract last track
cdparanoia can't extract last track
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
0.8.x
Other Linux
: Normal normal
: 0.8.11
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-07-03 13:03 UTC by Jonathan Matthew
Modified: 2005-07-11 12:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
obvious patch (1.35 KB, patch)
2005-07-03 13:06 UTC, Jonathan Matthew 		none Details | Review

Description Jonathan Matthew 2005-07-03 13:03:57 UTC 
The cdparanoia element can't extract the last track on the CD, as it thinks it
ends at sector 1.  cdparanoia_open() calculates last_sector by calling
get_first_sector(track+1); in this case, get_first_sector() relies on
last_sector already being set.

This breaks sound-juicer when extracting only the last track, amongst other
things.  It can also be reproduced using 'gst-launch-0.8 playbin uri=cdda://x'.
Comment 1 Jonathan Matthew 2005-07-03 13:06:58 UTC 
Created attachment 48584 [details] [review]
obvious patch

Ensures last_sector is set before calling get_first_sector.
Also fixes a typo in the description of the 'discid' property.
Comment 2 Tim-Philipp Müller 2005-07-04 22:22:33 UTC 
Are you using gst-plugins <= 0.8.9? If yes, isn't this the same as bug #307459?

 Cheers
  -Tim
Comment 3 Jonathan Matthew 2005-07-04 22:48:40 UTC 
I'm using 0.8 branch from CVS.  This bug still occurs with the fix for bug
#307459  in place.

bug #307459 caused an error when seeking to the last track, whereas this causes
the last track on the CD to EOS immediately if it's the first track played.

It turns out this doesn't affect sound-juicer after all (after getting it
working with gst-launch, I reverted to an older build without the fix for bug
#307459 to check if it affected s-j), but it's still reproducible with gst-launch.
Comment 4 Ronald Bultje 2005-07-11 12:28:19 UTC 
Applied, thanks.