4. Ability to set color of individual stickies

OK 4 is already possible.

Created attachment 48520 [details] [review]
Patch implementing 1, 2 and 3

So the patch does the following

1. Implement request 1
2. Implement request 2
3. Implement request 3
4. Removing the left click menu in the panel
5. Adding New note to the right click menu
6. Remove the key press callback (I wouldn't know how to do a keypress on the
panel applet)
7. Because of 1 and 2 it removes the visible setting from gconf

Please don't remove key presses. There are people who do use them for a variety
of reasons. I know it's non-intuative, but it's true.

I'll check out the rest of this patch later on.

Created attachment 48538 [details] [review]
Patch which keeps the keypress callback

Davyd, here's the patch that keeps the keypress and furthermore it's more
compliant to the coding style of sticky notes

Out of curiosity how can this keypress callback be activated?? I seem not to be
able to activate it

Something along the lines of ctrl-alt-tab will allow you to focus the panel. You
can then arrow across the applets and press Enter on it.

Clicking on the desktop and having them disappear is a little strange. Perhaps
instead the show/hide functionality should be exposed simply through the icon.

The double clicking is good.

Since you have the XID of the nautilus desktop, perhaps we can make the
stickynotes transient to that desktop (they wouldn't get minimised then when you
show desktop, I don't think). You can create a new GdkWindow* from an XID and
use the gdk_window_set_transient_for stuff.

With the exception of having them hide when you focus out (that's more then a
little strange) the rest of this seems good.

Oh, additionally. Clicking on the [x] on a note deletes the note, but the
tooltip says 'Close note' this is probably not the most useful tooltip.

Davyd, I'm not sure if understand your comments, but let me try to respond to
your comments and see if it gets clear to both of us

> With the exception of having them hide when you focus out (that's more then a
> little strange) the rest of this seems good.

The stickies are not hidden when you focus out. They just act as normal windows.
So if you just made a sticky and then maximize your browser, the sticky is
behind the browser window. 

This is IMHO a lot better then the current implementation keeping the sticky on
top of the browser window. Then it blocks text in your browser window that  you
might want to read

> Clicking on the desktop and having them disappear is a little strange. Perhaps
> instead the show/hide functionality should be exposed simply through the icon.

Here I basically use the same reasoning. I have my desktop full of file icons
and stickies might block these icons. So it's very handy that you can easily
hide them by just clicking or typing on the desktop.

What do think about this reasoning?

> Oh, additionally. Clicking on the [x] on a note deletes the note, but the
> tooltip says 'Close note' this is probably not the most useful tooltip.

That's not addressed by this patch. It's already there in CVS

> The stickies are not hidden when you focus out. They just act as normal windows.
> So if you just made a sticky and then maximize your browser, the sticky is
> behind the browser window. 

Sorry, I have been incredibly unclear here. This functionality is fine.

> Here I basically use the same reasoning. I have my desktop full of file icons
> and stickies might block these icons. So it's very handy that you can easily
> hide them by just clicking or typing on the desktop.

It's a very interesting idea. It's just somewhat unexpected when it actually
happens. What we really need is some visual indication of where your stickynotes
have just gone (think Apple expose). It also wasn't 100% clear how I hid them,
until I clicked on the desktop. This needs some thinking on.

Perhaps the icon should say 'Bring all stickynotes to the front' and then have
clicking on the desktop hide them with some visual indication they are being
hidden (it would be nice to make them translucent, but alas). It might also make
sense to have a 'hide stickynotes' option in the menu, in case you can't find
any free desktop space to click on, and they're getting in your way.

> That's not addressed by this patch. It's already there in CVS

Sure. I just noticed it at the same time. :)

What are your thoughts?

Good idea to change the tooltip of the icon. Other suggestion for the text might
be just simply "Show sticky notes". Also your suggestion is fine by me, I just
would write "sticky notes" instead of "stickynotes"

I agree that some visual cue would be a good idea. Do you have any idea on how
to do this with GTK?

What about first committing this and then adding a visual cue later? That would
be pretty local change. We just need to add some extra code in
"stickynote_show_notes (gboolean visible)"

Ok, commit it. It would be nice to clean up the strings at the same time. Be
sure to notify gnome-i18n of string changes, as we're in the announcement period.

> I agree that some visual cue would be a good idea. Do you have any idea on how
> to do this with GTK?

Not really, but perhaps look at the expose-metacity stuff. I'm just throwing
around ideas at the moment.

Can you commit it?
Don't have a cvs account.

I'll take a look at metacity

Created attachment 48985 [details] [review]
Previous patch + nice visual cue + updated tooltip

Tooltip now says:
---------------------
| Show sticky notes |
| xx notes	    |
--------------------

the nice visual cue was copied from this patch [1] proposed for rhythmbox.
It just uses the gtk_window_iconify and a bit of extra code to make the icon
dissapear in the panel icon.

Thanks for committing this patch. Closing this bug as being fixed

I see that I missed the reference in my previous comment. So here it is
[1] http://mail.gnome.org/archives/rhythmbox-devel/2005-July/msg00051.html