After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 307899 - handle iradio stream metadata
handle iradio stream metadata
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Internet Radio
HEAD
Other Linux
: Normal enhancement
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-06-16 11:04 UTC by Jonathan Matthew
Modified: 2005-07-31 14:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
lightly tested patch (6.63 KB, patch)
2005-06-16 11:05 UTC, Jonathan Matthew 		none Details | Review
updated patch (6.68 KB, patch)
2005-07-31 04:37 UTC, Jonathan Matthew 		committed Details | Review

Description Jonathan Matthew 2005-06-16 11:04:04 UTC 
With the patch from #307361, playbin emits found-tag signals for iradio metadata.
The patch I'm about to attach to this bug enables rhythmbox to display the
current song title and also fill in the genre and title for iradio stations
where the user hasn't provided them.
Comment 1 Jonathan Matthew 2005-06-16 11:05:58 UTC 
Created attachment 47855 [details] [review]
lightly tested patch

This replaces patches 16, 17, and 34 from my --bugs arch branch.
Comment 2 Christophe Fergeau 2005-06-16 11:12:04 UTC 
Didn't I merge part of it when I merged your playbin work ? Some iradio related
patch slipped in when I committed it ;)
Comment 3 Jonathan Matthew 2005-07-24 04:52:39 UTC 
It looks like the iradio metadata handling from 0.8 slipped in to the metadata
patch.  This patch still applies to current CVS HEAD.

The gstreamer patch (bug 307361) has been committed, but there has not been a
gst-plugins release since then.
Comment 4 Jonathan Matthew 2005-07-31 04:37:14 UTC 
Created attachment 49998 [details] [review]
updated patch

updated to apply to current CVS.
Comment 5 James "Doc" Livingston 2005-07-31 14:49:41 UTC 
2005-08-01  James Livingston  <jrl@ids.org.au>

        * player/rb-player-gst.c: (process_tag), (found_tag_cb),
        (rb_player_construct):
        * shell/rb-shell-player.c: (info_available_cb): patch from Jonathan
        Matthew <jonathan@kaolin.hn.org> to use iradio station metadata if the
        user hasn't provided them (Closes 307899)