After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 307697 - hide empty progress label
hide empty progress label
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
git master
Other Linux
: Normal trivial
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-06-14 23:12 UTC by Christian Persch
Modified: 2005-06-15 16:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix (607 bytes, patch)
2005-06-14 23:12 UTC, Christian Persch 		none Details | Review

Description Christian Persch 2005-06-14 23:12:08 UTC 
When the progress label in the fonts properties tab is empty, the empty space
under the treeview looks bad. The label should be hidden when not needed. Patch
follows.
Comment 1 Christian Persch 2005-06-14 23:12:20 UTC 
Created attachment 47776 [details] [review]
fix
Comment 2 Marco Pesenti Gritti 2005-06-15 00:20:24 UTC 
Not sure, doesnt this make the treeview size "jump"?
Comment 3 Christian Persch 2005-06-15 10:58:01 UTC 
When the scanning of fonts is complete, the label is hidden and the treeview
expands. I wouldn't say that's undesirable. Also, on a short document, I
switched to the fonts tab and the label was empty from the beginning, making me
wonder why that space was wasted.
Comment 4 Bryan W Clark 2005-06-15 13:07:51 UTC 
I have no opinion on this, defering to marco
Comment 5 Marco Pesenti Gritti 2005-06-15 14:08:17 UTC 
Well let's give this a try...

Do you still need gtk_label_set_text (GTK_LABEL (label), "");?

Please commit, thanks
Comment 6 Christian Persch 2005-06-15 16:20:08 UTC 
Don't need to set the label empty, no. Committed with that bit removed.