After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 307394 - Docs for gst_tag_setter_get_list are inconsistent
Docs for gst_tag_setter_get_list are inconsistent
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: documentation
0.8.10
Other Linux
: Normal normal
: 0.8.11
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-06-12 16:13 UTC by Torsten Schoenfeld
Modified: 2005-06-30 10:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch for the docs (900 bytes, patch)
2005-06-12 16:13 UTC, Torsten Schoenfeld
none Details | Review

Description Torsten Schoenfeld 2005-06-12 16:13:01 UTC
The docs for gst_tag_setter_get_list show G_CONST_RETURN for the returned tag
list, but also say it is to be freed with gst_tag_list_free() after use.  Those
two statements conflict with eachother.  Looking at the code:

  return gst_tag_setter_get_data (setter)->list;

it seems to me that the list shouldn't be freed, but I'm not sure.  In case this
is correct, here's a patch that changes the docs and the prototype to reflect
the situation.
Comment 1 Torsten Schoenfeld 2005-06-12 16:13:41 UTC
Created attachment 47654 [details] [review]
Patch for the docs
Comment 2 Ronald Bultje 2005-06-30 10:59:33 UTC
Applied to 0.8 and HEAD, thanks.