After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 307291 - leaks in nautilus-property-browser
leaks in nautilus-property-browser
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
0.x.x [obsolete]
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-06-11 14:12 UTC by Kjartan Maraas
Modified: 2005-07-06 20:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (1.22 KB, patch)
2005-06-11 14:13 UTC, Kjartan Maraas 		none Details | Review
updated patch (1.49 KB, patch)
2005-06-11 14:52 UTC, Kjartan Maraas 		needs-work Details | Review

Description Kjartan Maraas 2005-06-11 14:12:41 UTC 
==8732== 18536 (104 direct, 18432 indirect) bytes in 2 blocks are definitely
lost in loss record 18423 of 20645
==8732==    at 0x1B909B71: calloc (vg_replace_malloc.c:175)
==8732==    by 0x1C4E8FB7: g_malloc0 (gmem.c:154)
==8732==    by 0x1C4A40D0: g_type_create_instance (gtype.c:1576)
==8732==    by 0x1C48A20F: g_object_constructor (gobject.c:1052)
==8732==    by 0x1C48A861: g_object_newv (gobject.c:949)
==8732==    by 0x1C48B3EA: g_object_new_valist (gobject.c:1033)
==8732==    by 0x1C48B509: g_object_new (gobject.c:830)
==8732==    by 0x1C01C2EB: gdk_pixbuf_new_from_data (gdk-pixbuf-data.c:65)
==8732==    by 0x1C01A832: gdk_pixbuf_new (gdk-pixbuf.c:297)
==8732==    by 0x1BA989DE: gdk_pixbuf__png_image_load (io-png.c:294)
==8732==    by 0x1C01D15D: _gdk_pixbuf_generic_image_load (gdk-pixbuf-io.c:760)
==8732==    by 0x1C01D3B3: gdk_pixbuf_new_from_file (gdk-pixbuf-io.c:872)
==8732==    by 0x80764AF: make_category (nautilus-property-browser.c:1728)
==8732==    by 0x8076867: nautilus_property_browser_update_contents
(nautilus-property-browser.c:2002)
==8732==    by 0x1C4914AC: g_cclosure_marshal_VOID__VOID (gmarshal.c:77)
==8732==    by 0x1C4852FB: g_closure_invoke (gclosure.c:437)
==8732==    by 0x1C494A7E: signal_emit_unlocked_R (gsignal.c:2488)
==8732==    by 0x1C49605A: g_signal_emit_valist (gsignal.c:2247)
==8732==    by 0x1C4963E2: g_signal_emit (gsignal.c:2291)
==8732==    by 0x1BD0F1DE: gtk_button_clicked (gtkbutton.c:783)
==8732==    by 0x1BE69BD4: gtk_toggle_button_released (gtktogglebutton.c:462)
==8732==    by 0x1C4914AC: g_cclosure_marshal_VOID__VOID (gmarshal.c:77)
==8732==    by 0x1C484E28: g_type_class_meta_marshal (gclosure.c:514)
==8732==    by 0x1C4852FB: g_closure_invoke (gclosure.c:437)
==8732==    by 0x1C494302: signal_emit_unlocked_R (gsignal.c:2418)
==8732==    by 0x1C49605A: g_signal_emit_valist (gsignal.c:2247)
==8732==    by 0x1C4963E2: g_signal_emit (gsignal.c:2291)
==8732==    by 0x1BD0F162: gtk_button_released (gtkbutton.c:775)
==8732==    by 0x1BD102AC: gtk_button_button_release (gtkbutton.c:1211)
==8732==    by 0x1BDD236C: _gtk_marshal_BOOLEAN__BOXED (gtkmarshalers.c:83)
Comment 1 Kjartan Maraas 2005-06-11 14:13:32 UTC 
Created attachment 47613 [details] [review]
proposed patch
Comment 2 Kjartan Maraas 2005-06-11 14:37:05 UTC 
This is from the same area too:

==8732== 20788 (52 direct, 20736 indirect) bytes in 1 blocks are definitely lost
in loss record 19611 of 20645
==8732==    at 0x1B909B71: calloc (vg_replace_malloc.c:175)
==8732==    by 0x1C4E8FB7: g_malloc0 (gmem.c:154)
==8732==    by 0x1C4A40D0: g_type_create_instance (gtype.c:1576)
==8732==    by 0x1C48A20F: g_object_constructor (gobject.c:1052)
==8732==    by 0x1C48A861: g_object_newv (gobject.c:949)
==8732==    by 0x1C48B3EA: g_object_new_valist (gobject.c:1033)
==8732==    by 0x1C48B509: g_object_new (gobject.c:830)
==8732==    by 0x1C01C2EB: gdk_pixbuf_new_from_data (gdk-pixbuf-data.c:65)
==8732==    by 0x1C01A907: gdk_pixbuf_copy (gdk-pixbuf.c:334)
==8732==    by 0x1B9358C2: nautilus_customization_make_pattern_chit
(nautilus-customization-data.c:370)
==8732==    by 0x8076163: make_category (nautilus-property-browser.c:1762)
==8732==    by 0x8076867: nautilus_property_browser_update_contents
(nautilus-property-browser.c:2002)
==8732==    by 0x1C4914AC: g_cclosure_marshal_VOID__VOID (gmarshal.c:77)
==8732==    by 0x1C4852FB: g_closure_invoke (gclosure.c:437)
==8732==    by 0x1C494A7E: signal_emit_unlocked_R (gsignal.c:2488)
==8732==    by 0x1C49605A: g_signal_emit_valist (gsignal.c:2247)
==8732==    by 0x1C4963E2: g_signal_emit (gsignal.c:2291)
==8732==    by 0x1BD0F1DE: gtk_button_clicked (gtkbutton.c:783)
==8732==    by 0x1BE69BD4: gtk_toggle_button_released (gtktogglebutton.c:462)
==8732==    by 0x1C4914AC: g_cclosure_marshal_VOID__VOID (gmarshal.c:77)
==8732==    by 0x1C484E28: g_type_class_meta_marshal (gclosure.c:514)
==8732==    by 0x1C4852FB: g_closure_invoke (gclosure.c:437)
==8732==    by 0x1C494302: signal_emit_unlocked_R (gsignal.c:2418)
==8732==    by 0x1C49605A: g_signal_emit_valist (gsignal.c:2247)
==8732==    by 0x1C4963E2: g_signal_emit (gsignal.c:2291)
==8732==    by 0x1BD0F162: gtk_button_released (gtkbutton.c:775)
==8732==    by 0x1BD102AC: gtk_button_button_release (gtkbutton.c:1211)
==8732==    by 0x1BDD236C: _gtk_marshal_BOOLEAN__BOXED (gtkmarshalers.c:83)
==8732==    by 0x1C484E28: g_type_class_meta_marshal (gclosure.c:514)
==8732==    by 0x1C4852FB: g_closure_invoke (gclosure.c:437)

Should reset_chit be unrefed there too maybe?
Comment 3 Kjartan Maraas 2005-06-11 14:52:43 UTC 
Created attachment 47615 [details] [review]
updated patch

Found some more
Comment 4 Kjartan Maraas 2005-06-12 09:52:21 UTC 
There are some problems with these changes. I'll try to figure out which change
is breaking stuff
Comment 5 Kjartan Maraas 2005-07-06 20:22:33 UTC 
The relevant bits of this were commited.