After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 307281 - leak in gdkasync.c
leak in gdkasync.c
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: X11
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2005-06-11 12:55 UTC by Kjartan Maraas
Modified: 2005-06-12 17:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (477 bytes, patch)
2005-06-12 09:48 UTC, Kjartan Maraas 		none Details | Review

Description Kjartan Maraas 2005-06-11 12:55:37 UTC 
Valgrind reports this:

==8732== 40 bytes in 1 blocks are definitely lost in loss record 14197 of 20645
==8732==    at 0x1B909222: malloc (vg_replace_malloc.c:130)
==8732==    by 0x1C4E8F55: g_malloc (gmem.c:137)
==8732==    by 0x1BFACBFA: _gdk_x11_send_client_message_async (gdkasync.c:216)
==8732==    by 0x1BFB4AC6: xdnd_send_xevent (gdkdnd-x11.c:2185)
==8732==    by 0x1BFB4DCA: xdnd_send_enter (gdkdnd-x11.c:2281)
==8732==    by 0x1BFB77D1: gdk_drag_motion (gdkdnd-x11.c:3330)
==8732==    by 0x1BD5EB4F: gtk_drag_update_idle (gtkdnd.c:3491)
==8732==    by 0x1C4E4FFF: g_idle_dispatch (gmain.c:3812)
==8732==    by 0x1C4E2E5D: g_main_context_dispatch (gmain.c:1933)
==8732==    by 0x1C4E5C2D: g_main_context_iterate (gmain.c:2564)
==8732==    by 0x1C4E612E: g_main_loop_run (gmain.c:2768)
==8732==    by 0x1BDD0464: gtk_main (gtkmain.c:974)
==8732==    by 0x8070E89: main (nautilus-main.c:434)
Comment 1 Owen Taylor 2005-06-11 16:22:23 UTC 
Oops. Can you try adding g_free (state) after

       DeqAsyncHandler(state->dpy, &state->async);

in gdk/x11/gdkasync.c:send_event_handler()
Comment 2 Kjartan Maraas 2005-06-12 09:48:04 UTC 
Created attachment 47637 [details] [review]
patch

Seems to work
Comment 3 Owen Taylor 2005-06-12 14:04:33 UTC 
Looks good, please commit (gtk-2-6 and HEAD)
Comment 4 Kjartan Maraas 2005-06-12 17:26:05 UTC 
Commited on both branches.