GNOME Bugzilla – Bug 307142
don't hardwire "netscape" call
Last modified: 2005-06-11 17:57:56 UTC
Attached patch changes called command to gnome-open, which will decide about better browser.
Created attachment 47540 [details] [review] dia-callbrowser.patch
I think a similar patch might have been proposed already but we need a solution that will work in GTK only enviroments . I think a more complicated patch was proposed but I am not sure if anything has been committed. If I have time later I will try and find if this is in fact duplicate. Thank you for going to the effort of providing feedback, and especially for taking the extra effort of providing a patch.
Patch applied, thanks. 2005-06-10 Hans Breuer <hans@breuer.org> * app/commands.c : use "gnome-open" instead of "netscape" as fallback for $BROWSER not set. Still not optimal but better to try some common desktop tool than an obsolete browser;) Fixes bug #307142. Also some whitespace changes.
I was thinking of bug 147728 which is releated.
gnome-open is almost guaranteed to not work, as we already cover the HAVE_GNOME case in the start by calling gnome-help. If we don't have HAVE_GNOME, we're very unlikely to have gnome-open. This is worse than attempting netscape. We could also try a number of known browsers in turn.
You say there are no people ingnoring the miserable --with-gnome support ?? I'm one of them, but just have fixed a guaranteed crash for using Dia build --with-gnome and any command line option (I was also the on adding the crash, but quite some time ago:) Anyway changing the patch status to the current state.
Lars: thinking a little more about bug status change I feel it is pling wrong. - if you think "netscape" should stay, revert the change and set WONTFIX - if you think the issue is related to 147728, DUPLICATE - if you just want more open bugs, file some new. There are plenty of unreported bugs in Dia!