After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 306445 - stock icon for the "open recent" menu
stock icon for the "open recent" menu
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: [obsolete] stock-icons
unspecified
Other Linux
: Normal enhancement
: Small API
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2005-06-04 07:16 UTC by Emmanuele Bassi (:ebassi)
Modified: 2010-09-07 23:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
open recent stock icon 16x16 (632 bytes, image/png)
2005-06-04 07:17 UTC, Emmanuele Bassi (:ebassi)
  Details
open recent stock icon 24x24 (1.42 KB, image/png)
2005-06-04 07:18 UTC, Emmanuele Bassi (:ebassi)
  Details
24x24px 'recent items' (1.64 KB, image/png)
2007-06-05 11:35 UTC, Jakub Steiner
  Details
16x16px 'recent items' stock icon (921 bytes, image/png)
2007-06-05 11:36 UTC, Jakub Steiner
  Details
epiphany history icon (24x24px) (1.48 KB, image/png)
2007-06-13 21:51 UTC, Emmanuele Bassi (:ebassi)
  Details
16x16 and 24x24 LGPL'd icons (7.29 KB, application/x-bzip)
2007-09-06 20:13 UTC, Lapo Calamandrei
  Details
Use "document-open-recent" from the current theme in the file chooser (1007 bytes, patch)
2007-09-12 17:23 UTC, Emmanuele Bassi (:ebassi)
committed Details | Review

Description Emmanuele Bassi (:ebassi) 2005-06-04 07:16:59 UTC
proposed icons for the "open recent" menu item.
Comment 1 Emmanuele Bassi (:ebassi) 2005-06-04 07:17:51 UTC
Created attachment 47224 [details]
open recent stock icon 16x16
Comment 2 Emmanuele Bassi (:ebassi) 2005-06-04 07:18:22 UTC
Created attachment 47225 [details]
open recent stock icon 24x24
Comment 3 Matthias Clasen 2005-06-08 05:59:24 UTC
Seems a bit unclear to me. I would initially decipher this as "revert folder"... 
Comment 4 Emmanuele Bassi (:ebassi) 2005-06-08 07:19:50 UTC
I tried di maintain consistency with the revert icon - which is using "undo over
save" for its icon - by using the gtk-stock-redo icon; thus a recently opened
item is a "redo over open".
Comment 5 Alan Horkan 2005-07-05 16:11:11 UTC
I dont think the icon is as important as having a stock Item in gtk.  
Once the infrastructure/API is in place an icon can be sorted out later.  

I'm not sure I'd even bother using an icon that was different from the Icon for
Open, if I were going to use one at all.  Keep in mind this item should always
be leading to a submenu.  
Comment 6 Emmanuele Bassi (:ebassi) 2006-05-07 22:58:10 UTC
the recent files should also appear inside the file chooser. win32 and osx have both an icon for the recent files section of their file selection widgets, as far as I remember; maybe, instead of the "revert-open" we could use a clock on a folder/file like win32.
Comment 7 Jakub Steiner 2007-06-05 11:17:37 UTC
While the metaphor is hard, I think due to the fact the most exposed place will be the file dialog (16x16px icon), we should make it as simple as possible, focusing only on what's important - 'recent' ~ time.

I suggest using a clock/pocket watch/hand watch for this.
Comment 8 Jakub Steiner 2007-06-05 11:35:36 UTC
Created attachment 89403 [details]
24x24px 'recent items'
Comment 9 Jakub Steiner 2007-06-05 11:36:02 UTC
Created attachment 89404 [details]
16x16px 'recent items' stock icon
Comment 10 Matthias Clasen 2007-06-06 15:34:50 UTC
I'm not an artist; but I don't really think that metaphor works to convey the idea of recent documents to me. How about a stack of papers ?
Comment 11 Jakub Steiner 2007-06-07 00:27:47 UTC
The clock focuses on the 'recent' part. I think it's the differentiating element. Focusing on the document part means using the document sheet again --> visual noise. It's not fabulous, but it's recognizable in the context and with a text label I think.A paper sheet stack would look pretty much like a regular file.
Comment 12 Emmanuele Bassi (:ebassi) 2007-06-13 21:48:46 UTC
since a recent files list, in the context of the file chooser widgets, could be seen as a "history" like the one of a browser, the icon used by epiphany might help the user recognise the function. the icon is a clock with a small arrow superimposed, looking backward (I'm attaching it to the bug).
Comment 13 Emmanuele Bassi (:ebassi) 2007-06-13 21:51:20 UTC
Created attachment 89912 [details]
epiphany history icon (24x24px)

don't mean to steal it as it is, but the arrow is subtle enough to fit the 16x16px size too (epiphany has a 16x16 version of the icon).
Comment 14 Emmanuele Bassi (:ebassi) 2007-08-30 12:27:14 UTC
ping - gnome-icon-theme has the document-open-recent icon, which is released under the GPL license. I'd still like for gtk+ to have its own stock item, though.

I think that at least the GtkFileChooser widget should use document-open-recent for the recently used shortcut until gtk+ has a gtk-stock-open-recent stock item.
Comment 15 Lapo Calamandrei 2007-09-06 20:13:23 UTC
Created attachment 95085 [details]
16x16 and 24x24 LGPL'd icons

Here's the icons.
Comment 16 Emmanuele Bassi (:ebassi) 2007-09-12 17:23:16 UTC
Created attachment 95466 [details] [review]
Use "document-open-recent" from the current theme in the file chooser

this patch makes GtkFileChooserDefault use the "document-open-recent" icon from the current theme, and if not found, falls back to GTK_STOCK_FILE.

we can add one of the icons attached to this bug as "document-open-recent" to the icon-theme we provide as a fall back.
Comment 17 Matthias Clasen 2007-09-12 17:31:09 UTC
looks fine to me. do you feel up to figuring out how to add an icon to the builtin icon theme ?
Comment 18 Emmanuele Bassi (:ebassi) 2007-09-12 18:03:20 UTC
committed to trunk

2007-09-12  Emmanuele Bassi  <ebassi@gnome.org>

        * gtk/gtkfilechooserdefault.c (render_recent_icon): Use the
        "document-open-recent" icon for the the Recently Used shortcut
        in the file chooser. (#306445)

        * gtk/Makefile.am:
        * gtk/stock-icons/16/document-open-recent.png:
        * gtk/stock-icons/16/document-open-recent.svg:
        * gtk/stock-icons/24/document-open-recent.png:
        * gtk/stock-icons/24/document-open-recent.svg: Add the
        "document-open-recent" icon to the builtin theme we provide
        as a fallback.
Comment 19 Emmanuele Bassi (:ebassi) 2010-09-07 23:43:56 UTC
forgot to close after commit