After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 306426 - add PDB API for the the image grid
add PDB API for the the image grid
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: libgimp
unspecified
Other All
: Normal enhancement
: 2.4
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks: 101604
 
 
Reported: 2005-06-03 22:51 UTC by Sven Neumann
Modified: 2005-09-30 20:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix Makefiles (2.26 KB, patch)
2005-09-26 12:53 UTC, Sylvain FORET 		committed Details | Review
The image grid PDB API (6.75 KB, text/plain)
2005-09-26 12:54 UTC, Sylvain FORET 		  Details
A test for the image grid PDB API (3.48 KB, text/plain)
2005-09-26 12:56 UTC, Sylvain FORET 		  Details

Description Sven Neumann 2005-06-03 22:51:36 UTC 
A PDB API for the image grid would be nice to have. As a start, there should be
an API to read the grid spacings and grid offsets. Functions to modify the grid
can be added later.
Comment 1 Sven Neumann 2005-06-17 09:47:34 UTC 
Could be a nice task for someone who wants to get his hands dirty in GIMP code.
Please ask for advice on where to start.
Comment 2 Sylvain FORET 2005-09-26 12:53:03 UTC 
Created attachment 52668 [details] [review]
Fix Makefiles

This patch fixes the Makefile.am in

tools/pdbgen
libgimp
app/pdb

So that the new API compiles.

It also removes /*< pdb-skip >*/ from the GimpGridStyle enum so that it can be
accessed from the PDB API
Comment 3 Sylvain FORET 2005-09-26 12:54:41 UTC 
Created attachment 52669 [details]
The image grid PDB API

This adds the actual PDB API
Comment 4 Sylvain FORET 2005-09-26 12:56:18 UTC 
Created attachment 52671 [details]
A test for the image grid PDB API

This quick and dirty python plug-in tests the image grid PDB API.
Comment 5 Sven Neumann 2005-09-30 16:36:45 UTC 
Thanks, I have committed your patch with some smaller modifications.

2005-09-30  Sven Neumann  <sven@gimp.org>

	* app/core/core-enums.[ch]
	* libgimpbase/gimpbaseenums.[ch]: moved GimpGridStyle enum to
	libgimpbase.

	* app/core/gimpimage-grid.h: indentation.

	* app/pdb/Makefile.am
	* libgimp/Makefile.am
	* tools/pdbgen/Makefile.am
	* tools/pdbgen/pdb/grid.pdb: applied slightly modified patch by
	Sylvain FORET that adds a PDB API for the image grid.

	* app/pdb/grid_cmds.c
	* app/pdb/internal_procs.c
	* libgimp/gimp_pdb.h
	* libgimp/gimpenums.c.tail
	* libgimp/gimpgrid_pdb.[ch]
	* tools/pdbgen/enums.pl
	* tools/pdbgen/groups.pl: (re)generated.

	* libgimp/gimp.def
	* libgimpbase/gimpbase.def: updated.
Comment 6 Sven Neumann 2005-09-30 20:08:34 UTC 
Seems to work nicely :-) Closing as FIXED.