GNOME Bugzilla – Bug 306355
grep path needs to be customized
Last modified: 2009-08-15 18:40:50 UTC
gnome-search-tool uses /usr/bin/grep internally. But on Solaris, /usr/bin/grep does not support UTF-8 so we need to customize the path. Otherwise, gnome-search-tool cannot find files on Solaris. I'm attaching the patch.
Created attachment 47182 [details] [review] patch for configure.in, gsearchtool/Makefile.am and gsearchtool/gsearchtool.c I attached the patch. The patch can switch the grep path with the configure option.
Gnome-search-tool does not use /usr/bin/grep internally. It uses the first grep command found in the user's $PATH. Wouldn't it be easier to change PATH on Solaris so it uses the UTF-8 compatible version of grep by default?
Sorry, my description was not accurate. We hardly change the default $PATH. It would keep using /usr/bin but unfortunatelly some commands don't support UTF-8 under /usr/bin on Solaris. From the point of the archtectures and risk managements, we would like to customize the path of grep only. /usr/xpg4/bin/grep supports UTF-8 on Solaris. Could you integrate this fix for Solaris? In the current plan, /usr/bin/grep on Solaris will support EUC only.
Created attachment 47300 [details] [review] Proposed Patch I noticed your patch was against an old version of gnome-search-tool (2.6). The current stable version is at 2.10. ;-) I have ported your patch to CVS HEAD. Can you take a look at it before I apply it to CVS? Thanks.
Could you change the following line? < + g_strdup_printf ("'!' -type p -exec %s -i -c '%s' {} \\;", GREP_COMMAND); > + g_strdup_printf ("'!' -type p -exec %s -i -c '%%s' {} \\;", GREP_COMMAND); I confirmed other parts are no problem. Thanks for your modifying the patch.
Thanks. Patch applied to CVS HEAD.