After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 306238 - Screen reader stops reading from the second character of second line in evolution compose
Screen reader stops reading from the second character of second line in evolu...
Status: RESOLVED FIXED
Product: GtkHtml
Classification: Other
Component: Editing
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtkhtml-maintainers
Evolution QA team
Depends on:
Blocks: 271192
 
 
Reported: 2005-06-02 09:03 UTC by mengjie yu
Modified: 2005-07-06 10:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Here is the patch for the bug. (1.90 KB, patch)
2005-06-02 09:48 UTC, mengjie yu
none Details | Review
this is the src part (1.80 KB, patch)
2005-06-21 09:44 UTC, mengjie yu
none Details | Review
this is the a11y part (4.27 KB, patch)
2005-06-21 09:45 UTC, mengjie yu
none Details | Review
this is the src part. (3.56 KB, patch)
2005-07-06 10:15 UTC, mengjie yu
accepted-commit_now Details | Review
this is the a11y part. (4.27 KB, patch)
2005-07-06 10:16 UTC, mengjie yu
none Details | Review
this is the a11y part. (4.61 KB, patch)
2005-07-06 10:30 UTC, mengjie yu
accepted-commit_now Details | Review

Description mengjie yu 2005-06-02 09:03:12 UTC
1.Start Gnopernicus with Screen reader and Speech.
2.Start evolution with accessibility enabled and compose a mail.
3. type in some words in the first line. Then start a new line and continue typing.

Observation and Bug : 
1.Screen reader reads all key press events in first line.
2.Second line, after the first character, Screen reader stops reading characters
typed.
Comment 1 mengjie yu 2005-06-02 09:48:10 UTC
Created attachment 47130 [details] [review]
Here is the patch for the bug.
Comment 2 André Klapper 2005-06-02 11:47:15 UTC
adding patch keyword
Comment 3 Kaushal Kumar 2005-06-10 12:17:18 UTC
Mengjie: some review comments on the patch -

- in html_engine_delete, (e->cursor->offset-len) would become negative when we: 
    - select some text from the beginning of a line to a certain extent and
delete it.
    - keep the cursor at the beginning of a line and delete single characters.
So, do we really intend/need to pass this negative value to the signal handler?

- in the changelog entry, you have also included insert_empty_paragraph. we
should remove that.

- insert_object_for_undo changes are fine.

Thanks.
Comment 4 Radek Doulik 2005-06-13 09:31:12 UTC
the fix is wrong as we signal cursor position and not cursor offset. the
position is absolute position in the whole document. (the offset is offset in
the cursor object). you can use html_cursor_jump_to_position_no_spell to get the
offset (remember to use tmp cursor so that you don't modify engine's cursor)
Comment 5 mengjie yu 2005-06-21 09:44:13 UTC
Created attachment 48081 [details] [review]
this is the src part
Comment 6 mengjie yu 2005-06-21 09:45:17 UTC
Created attachment 48082 [details] [review]
this is the a11y part
Comment 7 mengjie yu 2005-06-21 09:55:43 UTC
Dear all
This is the new patch against this bug. 

As to your proposal, I signal the cursor position and get the offset of the text
inserted or deleted in the a11y part. 

Because gnopernicus need to check the text deleted before it is really deleted,
I emit the text_changed::delete signal before the deleing really happens.
Comment 8 Radek Doulik 2005-06-30 13:53:39 UTC
Hi Mengjie, we cannot emit the signal before deletion. It is called
object_deleted after all and also evo use that signal and depends on it.

Why do you need it signaled before?
Comment 9 mengjie yu 2005-07-01 07:59:18 UTC
Hi, Rodo

Firstly, actually I defined the object_deleted signal and I am the only person
who use this signal.

Secondly, I need it signaled before deletion because I need to access the
deleted text in a11y part. I'v check the source code of gtkentry. It does emit
corresponding signal before deleting. In addtion, gedit has the same behavior.
Comment 10 Kaushal Kumar 2005-07-06 06:33:26 UTC
Rodo: Can we commit the patch. Thanks.
Comment 11 mengjie yu 2005-07-06 10:14:00 UTC
Hi, ksh

I'v talked with rodo. He had agreed my signaling object_delete before really
deleting and I'v changed the name of the signal to object_delete as his proposal.

He also said if you think the other part of the patch is ok, I could commit it.


Here is the updated patch.
Comment 12 mengjie yu 2005-07-06 10:15:06 UTC
Created attachment 48709 [details] [review]
this is the src part.
Comment 13 mengjie yu 2005-07-06 10:16:30 UTC
Created attachment 48710 [details] [review]
this is the a11y part.
Comment 14 Kaushal Kumar 2005-07-06 10:22:20 UTC
Please commit to Head. Thanks for your work.
Comment 15 mengjie yu 2005-07-06 10:30:37 UTC
Created attachment 48711 [details] [review]
this is the a11y part.
Comment 16 mengjie yu 2005-07-06 10:36:05 UTC
Patch committed. 

Thanks for the review.