Created attachment 46974 [details] [review]
patch to add new button

I'm unsure what to do about this dialog (I was thinking of adding a "new game"
button myself this weekend). There are three options I can see:

i) Accept that this isn't an end-of-game dialog and leave it as it is.

ii) Decide that is really is an end-of-game dialog (like Aisleriot does when it
runs out of moves) and add the standard "New Game" and "Quit" buttons. This
gives us four buttons for the dialog - bad.

iii) ii), but remove the undo button. This makes running out of moves a penalty
offence and moves us away from the Aisleriot model. However, undo isn't
particularly useful in Mahjongg since the bad move was probably some twenty
moves back and very hard to spot. Worse still, hitting undo on the dialog as it
is now takes you back to a position where the only available move is the one you
just played, so you have to hit undo again (after moving the mouse to the normal
undo).

I'm very tempted to go for iii), it does seem to shut off an escape route, but I
don't think it is a viable one. I'm still thinking about this.

I like the first option of treating the game as if it isn't over.

Just adding a note that this is not a bug about adding "New Game" to the
highscore dialog after the end of a successful game, but looking at the recent
work on gnomine + high score dialog, that'll probably be taken care of soon enough.

I think you're right Richard, I'm closing this bug as WONTFIX.

Having said that I reserve the right to change my mind later - but I don't need
this bug hanging around to remind me.

I think this would be awesome.  There is another wish for it in Debian too.  http://bugs.debian.org/443474  - If I run out of moves in an unwinnable game, and cannot figure out how to back up and go a different way, I always want to start a new game.

This has been implemented in Debian gnome-games=1:2.30.2-1 - was the patch implemented upstream or not?