After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 305432 - smooth theme queries GtkButton style properties for all kind of widgets
smooth theme queries GtkButton style properties for all kind of widgets
Status: RESOLVED FIXED
Product: gtk-engines
Classification: Deprecated
Component: general
unspecified
Other Linux
: Normal major
: ---
Assigned To: gtk-engines maintainers
gtk-engines maintainers
Depends on:
Blocks:
 
 
Reported: 2005-05-25 14:28 UTC by Stefan Sauer (gstreamer, gtkdoc dev)
Modified: 2005-07-09 13:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
adds checks that widget is a button (812 bytes, patch)
2005-05-25 14:31 UTC, Stefan Sauer (gstreamer, gtkdoc dev)
committed Details | Review

Description Stefan Sauer (gstreamer, gtkdoc dev) 2005-05-25 14:28:16 UTC
engines/smooth/src/engine/smooth_gtk2_misc.c::gtk_button_get_props() is also
called for non GtkButton widgets (e.g. from smooth_gtk2_drawing.c::smooth_draw_box()
This breaks apps. It can be tested by building gtk+extra2 and run
src/testgtksheet in there. The GtkSheet widget is derived from a GtkContainer.
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2005-05-25 14:31:09 UTC
Created attachment 46872 [details] [review]
adds checks that widget is a button

The patch adds two GST_IS_BUTTON checks. This of cource renders the method name
questionable. If would be better named gtk_widget_get_props instead of
gtk_button_get_props.
Comment 2 Thomas Wood 2005-07-09 13:10:49 UTC
Patch applied to CVS