GNOME Bugzilla – Bug 305129
error when loading tvtime-output-13:17:10.png from command line
Last modified: 2006-08-10 02:44:48 UTC
Please describe the problem: when loading tvtime-output-13:17:10.png, or any filename with similar formatting causes eog to display a dialog with "File not found." renaming the file to something without colons fixes it. opening the file with file->open works fine also. Steps to reproduce: 1. $ eog tvtime-output-13\:17\:10.png -or- 2. $ eog "tvtime-output-13:17:10.png" 3. Actual results: a dialog with "File not found." occurs with eog closing after hitting ok. Expected results: i expected it to load the file as normal. Does this happen every time? yes. Other information: i haven't tried opening files with colons in any other gnome software. i also haven't tried any other funny characters.
I can reproduce this with EOG 2.12.1. Updating version.
I tested this with the latest cvs version and the bug seems to be gone.
Yes, right. Probably something fixed on gnome-vfs. Closing as obsolete. Feel free to reopen if you continue to have this problem.
Oops, made a mistake. The bug is still there... Reopening...
Well, the behaviour is quite strange in current CVS: When I open the file without specifiying a path to the file (open it from the current directory) EOG segfaults: $ eog tvtime-output-13\:16\:10.png libgnomevfs-CRITICAL **: gnome_vfs_uri_to_string: assertion `uri != NULL' failed aborting... I'll see if I can get a trace of it. When I add a path ('./' is sufficient) it loads fine: $ eog ./tvtime-output-13\:16\:10.png JPEG is sRGB
Created attachment 70138 [details] [review] possible fix (workaround?) The cause of the problem seems to have been gnome_vfs_make_uri_from_shell_arg() in make_canonical_uri(). It returned the input string instead of a valid uri string. This let gnome_vfs_uri_new() fail (and return NULL). This patch replaces it with gnome_vfs_make_uri_from_input_with_dirs () which seems to fix it. The problem with gnome_vfs_make_uri_from_shell_arg() should possibly still be opened as a gnome-vfs bug.
Commited in gnome-2-14, eog-ng, and HEAD branches. Thanks! 2006-08-10 Lucas Rocha <lucasr@gnome.org> * shell/main.c (make_canonical_uri): fix error when loading images with ':' in their filenames from command line (Fixes bug #305129). Patch from Felix Riemann <felix@hsgheli.de>.